Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40998: Address compiler warnings found by ubsan #20929

Merged
merged 2 commits into from Nov 18, 2020
Merged

bpo-40998: Address compiler warnings found by ubsan #20929

merged 2 commits into from Nov 18, 2020

Conversation

tiran
Copy link
Member

@tiran tiran commented Jun 17, 2020 •
edited by miss-islington

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue40998

Automerge-Triggered-By: GH:tiran

@tiran tiran force-pushed the bpo-40998-ubsan-warnings branch from 0a95a2c to 8da7b23 Compare Jun 17, 2020
@tiran tiran force-pushed the bpo-40998-ubsan-warnings branch from 8da7b23 to 6a35018 Compare Nov 18, 2020
pablogsal
pablogsal approved these changes Nov 18, 2020
View changes
Copy link
Member

@pablogsal pablogsal left a comment

LGTM

pablogsal
pablogsal reviewed Nov 18, 2020
View changes
Python/pylifecycle.c Outdated Show resolved Hide resolved
@tiran
Copy link
Member Author

tiran commented Nov 18, 2020

This PR also addresses a reference leak that was introduced in 86ea581 / GH-13159

vstinner
vstinner reviewed Nov 18, 2020
View changes
Python/_warnings.c Outdated Show resolved Hide resolved
@tiran tiran force-pushed the bpo-40998-ubsan-warnings branch from de6090b to 851deb9 Compare Nov 18, 2020
@tiran tiran added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Nov 18, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Nov 18, 2020

@tiran: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 07f2ade into python:master Nov 18, 2020
3 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Nov 18, 2020

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 18, 2020
@tiran @miss-islington
bpo-40998: Address compiler warnings found by ubsan (pythonGH-20929)
bb3401a 
Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: GH:tiran
(cherry picked from commit 07f2ade)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Nov 18, 2020

GH-23370 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Nov 18, 2020
@miss-islington @tiran
bpo-40998: Address compiler warnings found by ubsan (GH-20929)
994c68f 
Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: GH:tiran
(cherry picked from commit 07f2ade)

Co-authored-by: Christian Heimes <christian@python.org>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@tiran @adorilson
bpo-40998: Address compiler warnings found by ubsan (pythonGH-20929)
881b511 
Signed-off-by: Christian Heimes <christian@python.org>

Automerge-Triggered-By: GH:tiran
@tiran tiran mentioned this pull request May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

@pablogsal pablogsal

@lysnikolaou lysnikolaou

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tiran @miss-islington @bedevere-bot @vstinner @pablogsal @the-knights-who-say-ni