Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed allocation_number #2768

Merged
merged 4 commits into from Oct 5, 2020
Merged

Fixed allocation_number #2768

merged 4 commits into from Oct 5, 2020
+23 −32

Conversation

@shellhub
Copy link
Member

@shellhub shellhub commented Oct 4, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
shellhub added 3 commits Oct 4, 2020
@shellhub
fixed allocation_number
Loading status checks…
8449aed
@shellhub
fixed pre-commit
Loading status checks…
5d293ca
@shellhub
fixed line too long
Loading status checks…
0b53a41
@shellhub shellhub requested review from cclauss, poyea and dhruvmanila Oct 4, 2020
@dhruvmanila
dhruvmanila reviewed Oct 5, 2020
View changes
maths/allocation_number.py Outdated Show resolved Hide resolved
@shellhub
fixed bug
Loading status checks…
8242b6e
@shellhub shellhub requested a review from dhruvmanila Oct 5, 2020
@shellhub
Copy link
Member Author

@shellhub shellhub commented Oct 5, 2020

@dhruvmanila Please review again.
@dhruvmanila
dhruvmanila approved these changes Oct 5, 2020
View changes
@dhruvmanila dhruvmanila merged commit 437c725 into TheAlgorithms:master Oct 5, 2020
3 checks passed
3 checks passed
codespell
Details
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

@cclauss cclauss

@poyea poyea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@shellhub @dhruvmanila
You can’t perform that action at this time.