Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-gatsby): Update gatsby-minimal-starter #28040

Merged
merged 4 commits into from Nov 20, 2020
Merged

Conversation

@laurieontech
Copy link
Contributor

@laurieontech laurieontech commented Nov 13, 2020

This starter was originally created for use with recipes and is being repurposed to work with the new create-gatsby interactive CLI.

Note that this PR includes a change to the starters-publish script to prevent lock files from being generated for this specific starter. This will force the latest gatsby dependency and keep the dynamic installs of other packages in sync on latest.

laurieontech and others added 2 commits Nov 13, 2020
@gillkyle
Copy link
Contributor

@gillkyle gillkyle commented Nov 13, 2020

Added some more adjustments keeping it minimal, this is a screenshot in its current state:

image

@ascorbic
Copy link
Member

@ascorbic ascorbic commented Nov 16, 2020

Shall we just get this in, as even unfinished it's better than the current one?

@laurieontech laurieontech marked this pull request as ready for review Nov 17, 2020
@ascorbic ascorbic changed the title Update gatsby-minimal-starter feat(gatsby-minimal-starter): Update gatsby-minimal-starter Nov 20, 2020
@ascorbic ascorbic changed the title feat(gatsby-minimal-starter): Update gatsby-minimal-starter feat(create-gatsby): Update gatsby-minimal-starter Nov 20, 2020
@ascorbic ascorbic merged commit fe18a18 into master Nov 20, 2020
27 of 30 checks passed
27 of 30 checks passed
build-test Workflow: build-test
Details
ci/circleci: e2e_tests_pnp Your tests failed on CircleCI
Details
ci/circleci: starters_validate Your tests failed on CircleCI
Details
Cloud Tests
Details
Danger All good
Details
Peril All green. Good on 'ya.
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime_lazy_devjs Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-static-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_visual-regression Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_artifacts Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_cache_resilience Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_cli Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_ssr Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_structured_logging Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: mdx_e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: typecheck Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node12 Your tests passed on CircleCI!
Details
ci/circleci: windows_unit_tests Your tests passed on CircleCI!
Details
cypress: default-group 151 tests passed in 03:08
Details
@delete-merged-branch delete-merged-branch bot deleted the update-minimal-starter branch Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.