Skip to content

/ JSqlParser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: column names in INSERT statement should be simple, not FQN. #589

Open
wants to merge 1 commit into
base: master
from
Open

Fixed: column names in INSERT statement should be simple, not FQN. #589

wants to merge 1 commit into from

Conversation

@wheredevel
Copy link

@wheredevel wheredevel commented Mar 15, 2018

No description provided.

Pavel Bekkerman
Fixed: column names in INSERT statement should be simple, not FQN.
Loading status checks…
7d94935
@AnEmortalKid
AnEmortalKid reviewed Apr 6, 2018
View changes
src/main/java/net/sf/jsqlparser/schema/Column.java
* @return
*/
public String getName(boolean aliases) {
public String getFullyQualifiedName(boolean aliases) {

This comment has been minimized.

Sign in to view
@AnEmortalKid

AnEmortalKid Apr 6, 2018
Contributor

I believe this would force us to do a major version bump right?
src/main/java/net/sf/jsqlparser/schema/Column.java
* Get name.
* @return
*/
public String getName() {

This comment has been minimized.

Sign in to view
@AnEmortalKid

AnEmortalKid Apr 6, 2018
Contributor

Maybe update doc with “@return the simple name of the column. “
@wumpz
Copy link
Member

@wumpz wumpz commented Apr 6, 2018

I will not merge this, due to injecting a guava dependency for it.

@AnEmortalKid Why do you think we should make a main version update? The renaming looks reasonable and for this minimal change it would be to much I think to introduce version 2.
@AnEmortalKid
Copy link
Contributor

@AnEmortalKid AnEmortalKid commented Apr 6, 2018

@wumpz the method with signature getName(boolean) disappeared. Which is going to cause compilation errors for consumers. If you’re consuming it directly, that’s fine. However if you are pulling it in transitively in a war or assembly of sort, developers might not be wary of going to 1.2 and having things fail at runtime because the method disappeared.

From semver.org

Given a version number MAJOR.MINOR.PATCH, increment the:

MAJOR version when you make incompatible API changes,
MINOR version when you add functionality in a backwards-compatible manner, and
PATCH version when you make backwards-compatible bug fixes.
Additional labels for pre-release and build metadata are available as extensions to the MAJOR.MINOR.PATCH format.
@wumpz
Copy link
Member

@wumpz wumpz commented Apr 6, 2018

@AnEmortalKid wenn already had this discussion some time ago. 😋
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnEmortalKid AnEmortalKid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@wheredevel @wumpz @AnEmortalKid
You can’t perform that action at this time.