Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added conversion integer_to_roman #3840

Open
wants to merge 4 commits into
base: master
from
Open

Added conversion integer_to_roman #3840

wants to merge 4 commits into from

Conversation

@SherriChuah
Copy link

@SherriChuah SherriChuah commented Oct 30, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
SherriChuah added 4 commits Oct 30, 2020
@SherriChuah
Added conversion integer_to_roman
Loading status checks…
72ba838
@SherriChuah
Algorithim for integer to roman conversion
Loading status checks…
6dca787
@SherriChuah
Algorithm for integer to roman conversion
Loading status checks…
138a4e5
@SherriChuah
Integer to roman conversion
Loading status checks…
e16e0ec
@SherriChuah
Copy link
Author

@SherriChuah SherriChuah commented Oct 30, 2020

Im sorry but I do not know how to solve this issue. Can you help me?
@mrmaxguns
Copy link
Contributor

@mrmaxguns mrmaxguns commented Nov 4, 2020

  1. Trailing whitespace: looks like the file has unnecessary whitespaces (tabs/spaces) at the end of lines.
  2. Make sure to run black (the linter) before committing. To do so, run black conversions/integer_to_roman.py. (run pip install black to install black)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@SherriChuah @mrmaxguns
You can’t perform that action at this time.