Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update caesar_cipher.py #3860

Open
wants to merge 1 commit into
base: master
from
Open

Update caesar_cipher.py #3860

wants to merge 1 commit into from

Conversation

@MrGeek1337
Copy link

@MrGeek1337 MrGeek1337 commented Nov 2, 2020 •
edited

improved for conciseness and readability

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Improved existing algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@MrGeek1337
Update caesar_cipher.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b3454a9 
improved for conciseness and readability
@mrmaxguns
Copy link
Contributor

@mrmaxguns mrmaxguns commented Nov 4, 2020

This seems like the easiest and most pythonic way to do brute force.
@mrmaxguns
mrmaxguns reviewed Nov 4, 2020
View changes
ciphers/caesar_cipher.py Show resolved Hide resolved
@mrmaxguns
Copy link
Contributor

@mrmaxguns mrmaxguns commented Nov 5, 2020

@cclauss Could you review this PR?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmaxguns mrmaxguns

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@MrGeek1337 @mrmaxguns
You can’t perform that action at this time.