Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to change a vector only numbers with have multiple of x #3844

Open
wants to merge 2 commits into
base: master
from
Open

How to change a vector only numbers with have multiple of x #3844

wants to merge 2 commits into from
+25 −0

Conversation

@thiagomonteles
Copy link

@thiagomonteles thiagomonteles commented Oct 30, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@thiagomonteles
How to change a vector only numbers with have multiple of x
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0b949a3
@thiagomonteles
Update How_to_change-in_a_vector_only_numbers_with_have_multiple_for_…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
973f5ca 
…a_number_x.py
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 30, 2020

Travis tests have failed

Hey @thiagomonteles,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: ab7c4bf0-1afd-11eb-ae51-b75871e10011
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 30, 2020

Travis tests have failed

Hey @thiagomonteles,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 0f85e2a0-1afe-11eb-ae51-b75871e10011
@mrmaxguns
Copy link
Contributor

@mrmaxguns mrmaxguns commented Nov 4, 2020

Here is why pre-commit failed:

  1. Black failed. Make sure to run black on files before submitting a pull request
  2. Flake8 failed because matrix/How_to_change-in_a_vector_only_numbers_with_have_multiple_for_a_number_x.py:5:89: E501 line too long (105 > 88 characters)
  3. Codespell failed because "example" is misspelled on line 19.
  4. Filename validation failed because of uppercase characters and hyphens in the filename.

Because of this, Travis also failed.
@mrmaxguns
mrmaxguns suggested changes Nov 4, 2020
View changes
matrix/How_to_change-in_a_vector_only_numbers_with_have_multiple_for_a_number_x.py
You need create a function that check if an element X in a vector(list) is divisible for another number Y
'''

def change_multiple(change_to,multiple,vector):

This comment has been minimized.

Sign in to view
@mrmaxguns

mrmaxguns Nov 4, 2020
Contributor

Change to:

def change_multiple(change_to, multiple, vector):
    ...
matrix/How_to_change-in_a_vector_only_numbers_with_have_multiple_for_a_number_x.py
'''

def change_multiple(change_to,multiple,vector):
for i in range(len(vector)): # scroll through the list

This comment has been minimized.

Sign in to view
@mrmaxguns

mrmaxguns Nov 4, 2020
Contributor

No need to use range(len(...)) as we have enumerate:

for i, value in enumerate(vector):
    if value % multiple == 0:
        value = change_to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmaxguns mrmaxguns

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@thiagomonteles @TravisBuddy @mrmaxguns
You can’t perform that action at this time.