Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42461: show f_fsid when pring os.statvfs object #23511

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Rethan
Copy link

@Rethan Rethan commented Nov 25, 2020

Since python 3.7, f_fsid was added to os.statvfs, but it didn't show
up when print the object. So add one more field to output.

https://bugs.python.org/issue42461

Since python 3.7, f_fsid was added to os.statvfs, but it didn't show
up when print the object. So add one more field to output.
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Nov 25, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Rethan

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

github-actions bot commented Dec 31, 2020

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 31, 2020
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Works for me and a test case give right result. test_os shows
Ran 312 tests in 1.522s
OK (skipped=46)
== Tests result: SUCCESS ==
1 test OK.
Total duration: 1.7 sec
Tests result: SUCCESS
cpython on  fix-issue-42461 [$?] via 🐍 v3.11.0a5+

@Rethan
Copy link
Author

Rethan commented Mar 2, 2022

Works for me and a test case give right result. test_os shows Ran 312 tests in 1.522s OK (skipped=46) == Tests result: SUCCESS == 1 test OK. Total duration: 1.7 sec Tests result: SUCCESS cpython on  fix-issue-42461 [$?] via 🐍 v3.11.0a5+

Thank you for reviewing.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants