Skip to content

/ java-debug

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live Share debugging not working for client #324

Open
devsheder opened this issue Mar 20, 2020 · 7 comments
Open

Live Share debugging not working for client #324

devsheder opened this issue Mar 20, 2020 · 7 comments
Labels
needs more info

Comments

@devsheder
Copy link

@devsheder devsheder commented Mar 20, 2020

Hi !
I've noticed that we can't share debugging with clients during a live share session.
I'm using the latest version of Vs Code 1.43.1

Here is the vs code extensions I use :

  • Language Support for Java(TM) by Red Hat
  • Debugger for JavaPreview
  • Live Share Extension PackPreview : with setting "liveshare.allowGuestDebugControl": true

How to reproduce :

  • start a live share session
  • invite someone (a "client")
  • the client set a breakpoint in the code
  • the client launch the Java main program with Run launcher from Vs Code

What I see :

  • the debug is correctly started on my station (the server)
  • I see the execution stopped on the breakpoint (the line is coloured)
  • The client don't see the debugging toolbar and the coloured line

What I expect :

  • the client has access to the debug toolbar
  • the client can control the debugging

Thanks !
@testforstephen
Copy link
Contributor

@testforstephen testforstephen commented Mar 23, 2020 •
edited

the client launch the Java main program with Run launcher from Vs Code

What do you mean by "Run launcher from Vs Code"?

Is that the codelens above the main method?
image

Or Run in debug viewlet?
image

However, i tried both ways and here is what i saw.
When i tried the codelens in the client session, actually i got the error notification "The host doesn't allow running this command. If needed, ask them to enable it". In the user settings, i already enabled both liveshare.allowGuestDebugControl and liveshare.languages.allowGuestCommandControl, but still no luck.

When i tried the Run in the debug viewlet, i saw the debug toolbar in the both session window.
@devsheder
Copy link
Author

@devsheder devsheder commented Mar 25, 2020

Hi,
yes I was talking about Run in debug viewlet.
I'll try with the codelens one and will get back to you.
Thanks !
@devsheder
Copy link
Author

@devsheder devsheder commented Mar 26, 2020

Hi,
I think the problem is about my Mac Book Pro because two coworkers managed to share debug during a live share session.
I have no explanation....
@abiskop
Copy link

@abiskop abiskop commented May 11, 2020

For me, "liveshare.allowGuestCommandControl": true actually worked (as opposed to "liveshare.languages.allowGuestCommandControl": true, which the config UI generates), contrary to the highlighting in the JSON config editor which says that this setting does not exist.
@codeict
Copy link

@codeict codeict commented Oct 20, 2020 •
edited

This comment has been moved to MicrosoftDocs/live-share#3737 (comment)
@testforstephen
Copy link
Contributor

@testforstephen testforstephen commented Oct 21, 2020

@codeict Live Share is provided by another extension, need open an issue at https://github.com/MicrosoftDocs/live-share/issues?q= first to see what's the possible root cause.
@codeict
Copy link

@codeict codeict commented Oct 21, 2020

Sure, thank you soo much!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs more info
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@abiskop @testforstephen @devsheder @codeict
You can’t perform that action at this time.