Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pylint / flake8 compliant code in help pages #98

Open
bittner opened this issue Sep 15, 2018 · 1 comment
Open

Use Pylint / flake8 compliant code in help pages #98

bittner opened this issue Sep 15, 2018 · 1 comment
Labels

Comments

@bittner
Copy link
Member

@bittner bittner commented Sep 15, 2018

Help page 4 contains code examples that may need to be updated in order to promote common practice in Python programming.

Specifically, the for loop should use an "anonymous" count variable instead of i, e.g.

for _ in range(36):
    for _ in range(36):
        go(10)
        turn(10)
    turn(10)

Are the images available in a source code or editable image format, or just as pixel graphics?

@cool-RR
Copy link
Member

@cool-RR cool-RR commented Sep 15, 2018

Unfortunately the images are available just as pixel graphics. That's a very bad practice on my part. Or to be more precise, on 2009 Ram's part ;)

I disagree with your note about using underscores as the loop variable. I barely think it's important in production code, so in my opinion it's not remotely close to being important for the first loop that a complete beginner is writing.

If you'd be interested in improving or adding to the help pages, that'd be cool, but I haven't even built the installer for PythonTurtle in many years. So the first step before making any changes or additions would be to get a reliable build process going. I'm not going to do any of that, so unless you volunteer to do that, it's not likely that PythonTurtle could get stuff added to it. Sorry to be a downer.

@bittner bittner added the docs+guides label Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.