Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Treat single-character capital names as class instead of constant #34
Labels
Comments
|
Yeah, valid point. It really boils down to what is the more common use-case. However, we still plan on trying to make the highlighter more configurable and this may be a good configuration option to add. In the mean time I'll keep this thread open to let anyone else who might have an opinion on the matter chime in. |
|
Resolved as part of #42. Closing this issue now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, single-character words are highlighted like
ALL_CAPS_NAMES, but in practice they are usually class names instead, such asQandFobjects in Django.It might be better to change the highlighting rule of constants to require at least two characters instead. (Or even two uppercase characters because names like
_Nalso look like a class. This might just be me though.)