Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lint): added isort for import sorting #75

Merged
merged 1 commit into from Jul 19, 2020
Merged

chore(lint): added isort for import sorting #75

merged 1 commit into from Jul 19, 2020

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Jul 19, 2020 •
edited

  • pre-commit run --all-files to run it on all the files
  • It should run the isort etc. jobs before you commit

Probably you need to run pre-commit install after it's merged locally.

Let me know if the default preset is fine for you.

@coveralls
Copy link

@coveralls coveralls commented Jul 19, 2020 •
edited

Pull Request Test Coverage Report for Build 174930742

  • 40 of 40 (100.0%) changed or added relevant lines in 22 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 94.379%
Totals Coverage Status
Change from base Build 174792840: -0.004%
Covered Lines: 1444
Relevant Lines: 1530
💛 - Coveralls

@pavelfeldman pavelfeldman merged commit 59e6351 into microsoft:master Jul 19, 2020
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mxschmitt @coveralls @pavelfeldman