Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
hyperHTML.adopt(liveNode) #185
Open
Conversation
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
After the introduction of viperHTML
.adoptable = true, capable of creating a compact and compression friendly way to delimit all interpolations of a template literals, hyperHTML would like to re-introduce this ability lost wtih v2 release because unstable.All the basics are working but there are still two cases I cannot code cover because failing:
textaction is used the adoption shuold work properlyfindNode(...)internal function does not handle well thelevelvariable together with theindexOnce these two outstanding bugs are fixed, I will think about releasing v3 to include adopt within the library and branch out v2 for eventual emergency fixes.