Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-content seems included twice #315

Closed
brunoscopelliti opened this issue Dec 17, 2018 · 3 comments
Closed

create-content seems included twice #315

brunoscopelliti opened this issue Dec 17, 2018 · 3 comments

Comments

@brunoscopelliti
Copy link

@brunoscopelliti brunoscopelliti commented Dec 17, 2018

In the current latest version, @ungap/create-content seems to be included twice.

To verify, open previous link, and search for var createContent; you'll find matches for var createContent and var createContent$1, but the code is almost identical. Is this expected?

WebReflection added a commit that referenced this issue Dec 17, 2018
@brunoscopelliti
Copy link
Author

@brunoscopelliti brunoscopelliti commented Dec 17, 2018

Does your previous commit fix the issue with rollup, or we've to wait for a fix on rollup itself?

WebReflection added a commit that referenced this issue Dec 17, 2018
@WebReflection
Copy link
Owner

@WebReflection WebReflection commented Dec 17, 2018

I've monkey-patched the issue and took the opportunity to update the whole rollup stack, however not much gain once compressed since repeated content size is usually irrelevant.

anyway, good catch, thanks for filing this.

WebReflection added a commit that referenced this issue Dec 17, 2018
Fix #315 - include same dependencies once
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.