bpo-42504: fix for MACOSX_DEPLOYMENT_TARGET=11 #23556

fxcoudert · 2020-11-29T15:28:29Z

This pull request provides a fix for https://bugs.python.org/issue42504

https://bugs.python.org/issue42504

the-knights-who-say-ni · 2020-11-29T15:28:32Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@fxcoudert

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

fxcoudert · 2020-11-29T15:31:35Z

I have now signed the CLA

lewisrobbins · 2020-11-29T16:19:23Z

Looks good to me 👍

ned-deily

Thanks for the PR. There is more work to be done, though. With:

MACOSX_DEPLOYMENT_TARGET=11 ./configure

making this change in setup.py gets past the first error only to fail later in distutils/spawn.py:

  File "source/Lib/distutils/spawn.py", line 66, in spawn
    if _cfg_target_split > [int(x) for x in cur_target.split('.')]:
TypeError: '>' not supported between instances of 'NoneType' and 'list'

Are there other users of MACOSX_DEPLOYMENT_TARGET in the source that need to be changed as well?

bedevere-bot · 2020-11-30T04:08:25Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ronaldoussoren · 2020-11-30T08:26:10Z

A nicer fix is to ensure that sysconfig.get_config_var('MACOSX_DEPLOYMENT_TARGET') evaluates to a string. I haven't checked how easy it would be to do this.

fxcoudert · 2020-11-30T08:46:31Z

@ronaldoussoren the code at https://github.com/python/cpython/blob/3.9/Lib/sysconfig.py#L461 shows it's very deliberate that int-type values are returned as int

fxcoudert · 2020-11-30T09:34:15Z

Two places I am not 100% sure what to do:

https://github.com/python/cpython/blob/master/configure.ac#L1970 this assumes that cur_target="${cur_target_major}.${cur_target_minor}", so it may set MACOSX_DEPLOYMENT_TARGET to 11.0. I think that's acceptable.
https://github.com/python/cpython/blob/master/Mac/BuildScript/build-installer.py has lots of use cases, but I think they're all string-based, and therefore fine

fxcoudert · 2020-11-30T09:47:06Z

I have made the requested changes; please review again.
I have confirmed that this makes the formula build on 11.0 when setting MACOSX_DEPLOYMENT_TARGET=11 (https://github.com/Homebrew/homebrew-core/pull/65933/checks?check_run_id=1473199510)

Travis is telling me:

Fixing Python file whitespace ... 1 file:
  Lib/test/test_posix.py

but I haven't changed whitespace in this file, and it is not telling me what the issue actually is.

bedevere-bot · 2020-11-30T09:47:10Z

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

ned-deily

Thanks for the changes. Running test_distutils:
./python(.exe) -m test -w test_distutils

gives a number of failing test cases, basically due to one of two problems.

The missing str() at spawn.py:66
Failures in test_build_ext.py:501:

File "source/Lib/distutils/tests/test_build_ext.py", line 501, in _try_compile_deployment_target
    target = '%02d%02d00' % target
TypeError: not enough arguments for format string

I don't think we need to make any changes to configure.ac or build_installer.py.

ned-deily · 2020-12-01T02:22:08Z

Lib/distutils/spawn.py

@@ -57,7 +57,7 @@ def spawn(cmd, search_path=1, verbose=0, dry_run=0):
            _cfg_target = sysconfig.get_config_var(
                                  'MACOSX_DEPLOYMENT_TARGET') or ''
            if _cfg_target:
-                _cfg_target_split = [int(x) for x in _cfg_target.split('.')]
+                _cfg_target_split = [int(x) for x in str(_cfg_target).split('.')]


A similar change is needed below at line 66.

bedevere-bot · 2020-12-01T02:22:11Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

fxcoudert · 2020-12-01T08:27:26Z

I have made the requested changes; please review again.
There is still a whitespace failure about Lib/test/test_posix.py, but I haven't changed whitespace. I've ran make patchcheck but it fails, maybe I'm not doing it properly.

bedevere-bot · 2020-12-01T08:27:30Z

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

nilleb · 2020-12-01T21:42:52Z

I think there is one more occurrence to fix at subprocess.py line 1739: (👇 this is the fixed version)

                                val = os.fsencode(str(v))

because v is an environment variable value, and integers are not acceptable input values for os.fsencode

the-knights-who-say-ni added the CLA not signed label Nov 29, 2020

bedevere-bot added the awaiting review label Nov 29, 2020

fxcoudert mentioned this pull request Nov 29, 2020

Python@3.9 fails to install on ARM Big Sur Homebrew/homebrew-core#65866

Closed

5 of 5 tasks complete

guillochon approved these changes Nov 29, 2020

View changes

bedevere-bot added awaiting core review and removed awaiting review labels Nov 29, 2020

ned-deily requested changes Nov 30, 2020

View changes

bedevere-bot removed the awaiting core review label Nov 30, 2020

bedevere-bot added the awaiting changes label Nov 30, 2020

fxcoudert mentioned this pull request Nov 30, 2020

Python 3.9 Big Sur testing Homebrew/homebrew-core#65933

Closed

fxcoudert force-pushed the fxcoudert:patch-1 branch from 666d6d5 to cd26ccb Nov 30, 2020

bedevere-bot added awaiting change review and removed awaiting changes labels Nov 30, 2020

bedevere-bot requested a review from ned-deily Nov 30, 2020

ned-deily requested changes Dec 1, 2020

View changes

bedevere-bot added awaiting changes and removed awaiting change review labels Dec 1, 2020

fxcoudert mentioned this pull request Dec 1, 2020

Python 3.9.1 bigsur Homebrew/homebrew-core#65793

Closed

0 of 2 tasks complete

setup.py: fix for MACOSX_DEPLOYMENT_TARGET=11

Loading status checks…

884add1

fxcoudert force-pushed the fxcoudert:patch-1 branch from cd26ccb to 884add1 Dec 1, 2020

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Dec 1, 2020

fxcoudert requested a review from ned-deily Dec 1, 2020

bedevere-bot added awaiting change review and removed awaiting changes labels Dec 1, 2020

nwjsmith mentioned this pull request Dec 1, 2020

macOS 11 Big Sur compatibility on Apple Silicon Homebrew/brew#7857

Open

0 of 9 tasks complete

dtrodrigues mentioned this pull request Dec 2, 2020

molecule: update resource block instructions Homebrew/homebrew-core#66018

Open

2 of 5 tasks complete

python / cpython

bpo-42504: fix for MACOSX_DEPLOYMENT_TARGET=11 #23556

bpo-42504: fix for MACOSX_DEPLOYMENT_TARGET=11 #23556

fxcoudert commented Nov 29, 2020 •

edited by bedevere-bot

the-knights-who-say-ni commented Nov 29, 2020

fxcoudert commented Nov 29, 2020

lewisrobbins commented Nov 29, 2020

ned-deily left a comment

bedevere-bot commented Nov 30, 2020

ronaldoussoren commented Nov 30, 2020

fxcoudert commented Nov 30, 2020

fxcoudert commented Nov 30, 2020

fxcoudert commented Nov 30, 2020 •

edited

bedevere-bot commented Nov 30, 2020

ned-deily left a comment

This comment has been minimized.

bedevere-bot commented Dec 1, 2020

fxcoudert commented Dec 1, 2020

bedevere-bot commented Dec 1, 2020

nilleb commented Dec 1, 2020

python / cpython

Sponsor python/cpython

Join GitHub today

GitHub is where the world builds software

bpo-42504: fix for MACOSX_DEPLOYMENT_TARGET=11 #23556

bpo-42504: fix for MACOSX_DEPLOYMENT_TARGET=11 #23556

Conversation

fxcoudert commented Nov 29, 2020 • edited by bedevere-bot

the-knights-who-say-ni commented Nov 29, 2020

CLA Missing

fxcoudert commented Nov 29, 2020

lewisrobbins commented Nov 29, 2020

ned-deily left a comment

bedevere-bot commented Nov 30, 2020

ronaldoussoren commented Nov 30, 2020

fxcoudert commented Nov 30, 2020

fxcoudert commented Nov 30, 2020

fxcoudert commented Nov 30, 2020 • edited

bedevere-bot commented Nov 30, 2020

ned-deily left a comment

This comment has been minimized.

ned-deily Dec 1, 2020 • edited Member

bedevere-bot commented Dec 1, 2020

fxcoudert commented Dec 1, 2020

bedevere-bot commented Dec 1, 2020

nilleb commented Dec 1, 2020

Essential cookies

Always active

Analytics cookies

fxcoudert commented Nov 29, 2020 •

edited by bedevere-bot

fxcoudert commented Nov 30, 2020 •

edited

ned-deily Dec 1, 2020 •

edited

Member