Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Mandelbrot fractal generator #3831

Open
wants to merge 15 commits into
base: master
from
Open

Added Mandelbrot fractal generator #3831

wants to merge 15 commits into from

Conversation

@jrmiranda
Copy link
Contributor

@jrmiranda jrmiranda commented Oct 30, 2020

Describe your change:

Added a Mandelbrot set generator.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
jrmiranda and others added 12 commits Oct 11, 2020
@jrmiranda
Fetch CO2 emission information
Loading status checks…
6383fbd
@jrmiranda
fix blank lines
Loading status checks…
4ae8aab
@jrmiranda
fix blank lines
Loading status checks…
42a4bdf
@cclauss
Add type hints for function return values
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
587212d
@cclauss
Update co2_emission.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c5e1d31
@cclauss
Update co2_emission.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9cf4d64
@cclauss
Update co2_emission.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1bddff7
@jrmiranda
Adding Mandelbrot Set
214d7e7
@jrmiranda
Merge branch 'master' of https://github.com/TheAlgorithms/Python into…
a6a3279 
… master
github-actions github-actions
updating DIRECTORY.md
7847042
@jrmiranda
Added Mandelbrot Set
d84cf36
@jrmiranda
Merge branch 'master' of https://github.com/jrmiranda/Python into master
6ff3363
@jrmiranda jrmiranda requested a review from Kush1101 as a code owner Oct 30, 2020
@jrmiranda
Fix end of file
Loading status checks…
8ca8e9d
@jrmiranda jrmiranda force-pushed the jrmiranda:master branch from 1f0d9f8 to 8ca8e9d Oct 30, 2020
@jrmiranda
Fix whitespaces
Loading status checks…
c11c981
@mrmaxguns
Copy link
Contributor

@mrmaxguns mrmaxguns commented Nov 5, 2020

Maybe put the algorithm in a function? Something like:

def generate_mandelbrot_image(width, height, location, ...):
    ...
@jrmiranda
added generate mandelbrot set function
Loading status checks…
887804b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kush1101 Kush1101

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@jrmiranda @mrmaxguns @cclauss
You can’t perform that action at this time.