Skip to content

Update embed-files.md#1260

Closed
dkvadratu wants to merge 2 commits into
docsifyjs:developfrom
dkvadratu:patch-1
Closed

Update embed-files.md#1260
dkvadratu wants to merge 2 commits into
docsifyjs:developfrom
dkvadratu:patch-1

Conversation

@dkvadratu

@dkvadratu dkvadratu commented Jul 2, 2020

Copy link
Copy Markdown

When adding Video, remember to add tag: controls after Width or Height, because I was missing video play button and i thought that video doesn't work. Also .webm format works.

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • DO NOT include files inside lib directory.

When adding Video, remember to add tag: controls after Width or Height, because I was missing video play button and i thought that video doesn't work. Also .webm format works.
@vercel

vercel Bot commented Jul 2, 2020

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/arnd6x4re
✄1�7 Preview: https://docsify-preview-git-fork-dkvadratu-patch-1.docsify-core.vercel.app

@codesandbox-ci

codesandbox-ci Bot commented Jul 2, 2020

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@sy-records sy-records changed the base branch from master to develop September 21, 2020 10:25
@sy-records

Copy link
Copy Markdown
Member

It was found that the upstream had been deleted, so the closure was performed first.
If needed, a new PR can be submitted

@sy-records sy-records closed this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants