bpo-32381: Remove unused _Py_fopen() function #23711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the private _Py_fopen() function which is no longer needed. Use _Py_wfopen` or _Py_fopen_obj() instead.
|
Using a bytes string for a filename causes encoding headaches likes https://bugs.python.org/issue32381 It's better to use wide character strings or Unicode strings for filenames. |
|
See also https://bugs.python.org/issue42569 |
|
Boost is affected by the removal: https://bugzilla.redhat.com/show_bug.cgi?id=1912903 |
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Remove the private _Py_fopen() function which is no longer needed. Use _Py_wfopen() or _Py_fopen_obj() instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the private _Py_fopen() function which is no longer needed.
Use _Py_wfopen` or _Py_fopen_obj() instead.
https://bugs.python.org/issue32381