Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Link to issue regarding logging.disable level param default value #23726

Merged
merged 1 commit into from Dec 9, 2020
Merged

[doc] Link to issue regarding logging.disable level param default value #23726

merged 1 commit into from Dec 9, 2020

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Dec 9, 2020 •
edited by miss-islington

Automerge-Triggered-By: GH:orsenthil

@andresdelfino andresdelfino requested a review from vsajip as a code owner Dec 9, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 9, 2020
@orsenthil orsenthil added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Dec 9, 2020
@miss-islington miss-islington merged commit 2a35137 into python:master Dec 9, 2020
3 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Dec 9, 2020

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@andresdelfino andresdelfino deleted the link_to_critical_issue branch Dec 9, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Dec 10, 2020

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Dec 10, 2020

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@orsenthil
Copy link
Member

orsenthil commented Dec 10, 2020

Looks like miss-islington could not backport this.
@andresdelfino , if you don't mind backporting your patch to 3.9 and 3.8 docs, please contribute them. I will review/merge it.

@andresdelfino
Copy link
Contributor Author

andresdelfino commented Dec 10, 2020

Looks like miss-islington could not backport this.
@andresdelfino , if you don't mind backporting your patch to 3.9 and 3.8 docs, please contribute them. I will review/merge it.

Yes, of course!

@miss-islington
Copy link
Contributor

miss-islington commented Dec 10, 2020

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Dec 10, 2020

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@andresdelfino andresdelfino mentioned this pull request Dec 10, 2020
Merged
@bedevere-bot
Copy link

bedevere-bot commented Dec 10, 2020

GH-23731 is a backport of this pull request to the 3.8 branch.

andresdelfino added a commit to andresdelfino/cpython that referenced this pull request Dec 10, 2020
@andresdelfino
[3.8] [doc] Link to issue regarding logging.disable level param defau…
6039a9e 
…lt value (pythonGH-23726)

(cherry picked from commit 2a35137)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@andresdelfino andresdelfino mentioned this pull request Dec 10, 2020
Merged
@bedevere-bot
Copy link

bedevere-bot commented Dec 10, 2020

GH-23732 is a backport of this pull request to the 3.9 branch.

andresdelfino added a commit to andresdelfino/cpython that referenced this pull request Dec 10, 2020
@andresdelfino
[3.9] [doc] Link to issue regarding logging.disable level param defau…
5ad8c03 
…lt value (pythonGH-23726)

(cherry picked from commit 2a35137)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Dec 13, 2020

Sorry, @andresdelfino, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2a35137328154aa2513649dcf0bbef02c998e27c 3.9

@miss-islington miss-islington self-assigned this Dec 13, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Dec 13, 2020

Sorry, @andresdelfino, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2a35137328154aa2513649dcf0bbef02c998e27c 3.8

@miss-islington
Copy link
Contributor

miss-islington commented Dec 13, 2020

Sorry @andresdelfino, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 2a35137328154aa2513649dcf0bbef02c998e27c 3.9

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@andresdelfino @adorilson
[doc] Link to issue regarding logging.disable level param default val…
8f10bcb 
…ue (pythonGH-23726)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil

@vsajip vsajip

Assignees

@miss-islington miss-islington

Labels
docs Documentation in the Doc dir 🤖 automerge PR will be merged once it's been approved and all CI passed skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andresdelfino @miss-islington @orsenthil @bedevere-bot @the-knights-who-say-ni