Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified comments on upper.py ,made it more clean #3884

Merged
merged 4 commits into from Nov 18, 2020

Conversation

@sethusankar
Copy link
Contributor

@sethusankar sethusankar commented Nov 13, 2020

Describe your change:

fixes: #3807

This is just a word change in the comments section to make the comments look more readable. No other issues are expected as a part of this change.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.

  • This pull request is all my own work -- I have not plagiarized.

  • I know that pull requests will not be merged if they fail the automated tests.

  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.

  • All new Python files are placed inside an existing directory.

  • All filenames are in all lowercase characters with no spaces or dashes.

  • All functions and variable names follow Python naming conventions.

  • All function parameters and return values are annotated with Python type hints.

  • All functions have doctests that pass the automated testing.

  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation

  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{3807}.

Copy link
Contributor Author

@sethusankar sethusankar left a comment

This should fix issue 3807

@xcodz-dot
Copy link
Contributor

@xcodz-dot xcodz-dot commented Nov 16, 2020

add the following line to your PR body fixes: #3807 to link it to that issue

strings/upper.py Outdated Show resolved Hide resolved
Co-authored-by: xcodz-dot <71920621+xcodz-dot@users.noreply.github.com>
Copy link
Contributor Author

@sethusankar sethusankar left a comment

fixes: #3807

@xcodz-dot
Copy link
Contributor

@xcodz-dot xcodz-dot commented Nov 17, 2020

fixes: #3807

not here, edit your top PR body

dhruvmanila added 2 commits Nov 18, 2020
@dhruvmanila dhruvmanila merged commit b31ed8c into TheAlgorithms:master Nov 18, 2020
2 checks passed
2 checks passed
pre-commit pre-commit
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.