Skip to content

/ practical-modern-javascript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sentence syntax #69

Merged
merged 2 commits into from Oct 16, 2018
Merged

update sentence syntax #69

merged 2 commits into from Oct 16, 2018

Conversation

@andreidobrinski
Copy link
Contributor

@andreidobrinski andreidobrinski commented Oct 12, 2018

No description provided.

@andreidobrinski
update sentence syntax
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
b3593a5
@bevacqua
Copy link
Member

@bevacqua bevacqua commented Oct 16, 2018

This breaks the link on GitHub (see rendered version). AsciiDoc rendering is funnier than it might seem at first glance. Also the O'Reilly rendered (used by Pony Foo and also their underlying book-formatting efforts) is different from the one used on GitHub (different versions of same software)

screen shot 2018-10-15 at 22 28 52
@bevacqua
Copy link
Member

@bevacqua bevacqua commented Oct 16, 2018

Example of what I mentioned earlier, based on the changes in #68

GitHub renders footnote references inline:

screen shot 2018-10-15 at 22 33 00

Whereas O'Reilly Atlas (thus Pony Foo), renders footnote references using anchors:

screen shot 2018-10-15 at 22 32 36

screen shot 2018-10-15 at 22 32 51
@andreidobrinski
fix breaking link
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
f27bd30
@andreidobrinski
Copy link
Contributor Author

@andreidobrinski andreidobrinski commented Oct 16, 2018

Thanks! Hope this works.
@bevacqua bevacqua merged commit 13e0158 into mjavascript:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@andreidobrinski @bevacqua
You can’t perform that action at this time.