Skip to content

/ practical-modern-javascript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ch08: Fix footnote. Fix mixed brackets. #72

Merged
merged 1 commit into from Oct 14, 2020
Merged

ch08: Fix footnote. Fix mixed brackets. #72

merged 1 commit into from Oct 14, 2020

Conversation

@vladimirze
Copy link
Contributor

@vladimirze vladimirze commented Apr 27, 2019

  • changed <span class=footnote"... to <span data-type="footnote" (footnote is incorrectly shown in PDF version, I assume this should fix it)
  • from "...in the [0, n) range" to "...in the [0, n] range"
@bevacqua
Copy link
Member

@bevacqua bevacqua commented Jun 19, 2019

-1 to the second bit, [0, n) is correct. It means 0 is included in the output range but n isn't. It's not mixed brackets, it's maths notation
@bevacqua
Copy link
Member

@bevacqua bevacqua commented Jun 19, 2019

You reverted the wrong change 😅
@vladimirze
ch08: Fix footnote
ffa31d6
@vladimirze vladimirze force-pushed the vladimirze:ch08-fixes branch from 747e73c to ffa31d6 Jun 19, 2019
@vladimirze
Copy link
Contributor Author

@vladimirze vladimirze commented Sep 17, 2019

I fixed the change. Does this looks better?
@bevacqua bevacqua merged commit 0275704 into mjavascript:master Oct 14, 2020
@bevacqua
Copy link
Member

@bevacqua bevacqua commented Oct 14, 2020

Thanks. Sorry for the delay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@vladimirze @bevacqua
You can’t perform that action at this time.