Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix grammar and construction in 2.1.10 #1672
Merged
Conversation
|
All good or at least OK by me (as far as I noticed) except as noted. |
|
/me stands with @paroche on the review comments, please update the PR :) |
|
@galacemiguel Could you please fix the PR according to the suggestions? |
|
ping @galacemiguel |
Sorry, this one slipped my mind. Getting to it now! @iliakan |
|
Wow! So I've got to review it again! ;) |
|
Great, thanks! |
8cb4268
into
javascript-tutorial:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
There were various grammatical and construction-related errors in the Window sizes and scrolling article. I did my best to correct them.
Please let me know if I made a mistake myself! Thank you!