Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rtd config file with htmldir builder #493

Open
wants to merge 1 commit into
base: master
from

Conversation

@willingc
Copy link
Collaborator

@willingc willingc commented Jun 9, 2019

This PR is a follow-up to #481 and the redirect issue in #483.

This adds the ReadTheDocs configuration file which is the preferred build method for RTD.

Unlike #481, this PR specifies that the sphinx builder should user dirhtml instead of the default html. Reference in Sphinx docs

@JulienPalard, would you mind doing the review on this? Happy to answer any specific questions about it. Thanks.

@willingc
Copy link
Collaborator Author

@willingc willingc commented Jun 9, 2019

@JulienPalard I also made you a maintainer of the devguide in ReadTheDocs.

@JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented Jul 9, 2019

LGTM with nits: Can you add a newline at end of file?

@eamanu
eamanu approved these changes Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.