Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix good commit example to use imperative title #587
Merged
Conversation
- Fix example to use imperative title - Explicitly mention the preference for imperative over descriptive titles - Link to the article from Chris Beams
|
Thanks for the PR @DahlitzFlorian. It mostly LGTM; I just have a very minor suggestion. Since this issue is very well defined and straightforward, I'm good w/ merging it after the suggested changes are made. |
|
Thanks for the fast feedback @aeros! I applied your suggestion. |
|
Approve other than one case issue. |
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
|
LGTM. Kyle, leaving this for you if you get to it. |
Co-authored-by: Kyle Stanley <aeros167@gmail.com>
|
With the latest changes, LGTM. Thanks for working on this @DahlitzFlorian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Closes: #577
@gvanrossum I added the link to the article as suggested by you. The Git Bootcamp is mentioning the article, too, but I agree with you that it is better to explicitly mention it at this point, too.