C#: Extract init only accessors from CIL #4821
Conversation
1050ebf to
50343da
Compare
50343da to
dcbcc88
Compare
dcbcc88 to
f3a0d1d
Compare
csharp/extractor/Semmle.Extraction.CIL/Entities/ModifiedType.cs
Outdated
Show resolved
Hide resolved
|
|
||
| public override void WriteAssemblyPrefix(TextWriter trapFile) => Unmodified.WriteAssemblyPrefix(trapFile); | ||
|
|
||
| public override void WriteId(TextWriter trapFile, bool inContext) |
There was a problem hiding this comment.
I reckon this should never be called? So throw NotImplementedException would be better.
There was a problem hiding this comment.
True. It would be a bug, if it was called.
|
|
||
| public override string Name => Unmodified.Name + (IsRequired ? " modreq" : " modopt") + $"({Modifier.Name})"; | ||
|
|
||
| public override void WriteAssemblyPrefix(TextWriter trapFile) => Unmodified.WriteAssemblyPrefix(trapFile); |
There was a problem hiding this comment.
Should this ever be called?
There was a problem hiding this comment.
No, changed it to an exception throwing.
|
@hvitved I found some perf issue in the differences job. The below shows up in the roslyn snapshot1 log, but not in snapshot0: I also found the below line with a huge number of rows: Can we have a look together? I'don't know how to move forward with this issue. |
|
Oh no, we are running into the BDD issue again 😱 |
Apparently fixed by my latest change 🤷♂️ |
initaccessors are normalsetaccessors in IL, except that there's amodreqapplied to them. To extract thismodreqormodoptthis PR introduces aModifiedType, which references the unmodified type, the modifier, and the isRequired flag. These types are not written to the trapfiles, which means that when aModifiedTypewould be written to a trapfile, we need to get the underlying unmodified type and write that instead. This is a bit error prone, because I didn't yet find a clear specification on where these modifiers can show up, but it looks like there are not that many places (fields, properties, methods, parameters and function pointers). See first bullet point in this remark.Still missing: