Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ts migration/convert yurnalist logger #24224

Merged
merged 9 commits into from May 20, 2020

Conversation

@blainekasten
Copy link
Contributor

@blainekasten blainekasten commented May 19, 2020

Description

Converts the last logger.
Also fixes up a few things from previous merges

Related Issues

Related to #21995

@blainekasten blainekasten requested a review from gatsbyjs/core as a code owner May 19, 2020
@blainekasten blainekasten mentioned this pull request May 19, 2020
223 of 264 tasks complete
Copy link
Contributor

@pvdz pvdz left a comment

dangit github, at least let me tell you to compare two files rather than just considering a rename a delete and new instead :(

Anyways, nice

@pvdz
pvdz approved these changes May 20, 2020
@gatsbybot gatsbybot merged commit 342d835 into master May 20, 2020
27 checks passed
27 checks passed
Cloud Tests
Details
Danger All good
Details
Gatsby Build Service Gatsby Build Service
Details
Peril All green. Congrats.
Details
TypoCheck No typos found
Details
build-test Workflow: build-test
Details
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_gatsby-image Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_path-prefix Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_pnp Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_cache_resilience Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_cli Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_gatsby_pipeline Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_long_term_caching Your tests passed on CircleCI!
Details
ci/circleci: integration_tests_structured_logging Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: starters_validate Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_development_runtime Your tests passed on CircleCI!
Details
ci/circleci: themes_e2e_tests_production_runtime Your tests passed on CircleCI!
Details
ci/circleci: typecheck Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node10 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_node12 Your tests passed on CircleCI!
Details
ci/circleci: unit_tests_www Your tests passed on CircleCI!
Details
ci/circleci: windows_unit_tests Your tests passed on CircleCI!
Details
cypress: default-group 139 tests passed in 02:59
Details
@delete-merged-branch delete-merged-branch bot deleted the ts-migration/convert-yurnalist-logger branch May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.