Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions #230

Merged
merged 31 commits into from Jul 3, 2020
Merged

Functions #230

merged 31 commits into from Jul 3, 2020

Conversation

@vplentinax
Copy link
Contributor

@vplentinax vplentinax commented Jun 5, 2020 •
edited

Este PR es la corrección al articulo traducido por el colaborador Giorgiosaud Functions #96 . Dicho PR será cerrado y reenumerado en el Issue 17.
@vplentinax
Giorgiosaud-PR95-correccion
Loading status checks…
76be9f6
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Jun 5, 2020
@vplentinax vplentinax changed the title Giorgiosaud-PR95-correccion Conditional operators: if, '?' Jun 5, 2020
@iliakan iliakan mentioned this pull request Jun 5, 2020
Open
159 of 174 tasks complete
@vplentinax vplentinax requested review from EzequielCaste and joaquinelio Jun 5, 2020
@vplentinax vplentinax changed the title Conditional operators: if, '?' Functions Jun 5, 2020
@EzequielCaste
EzequielCaste requested changes Jun 15, 2020
View changes
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

casi listo, algunas correcciones
1-js/02-first-steps/15-function-basics/1-if-else-required/task.md Outdated Show resolved Hide resolved
...02-first-steps/15-function-basics/2-rewrite-function-question-or/task.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jun 15, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
EzequielCaste and others added 16 commits Jun 15, 2020
@EzequielCaste
Update 1-js/02-first-steps/15-function-basics/1-if-else-required/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f95071e
@EzequielCaste
Update 1-js/02-first-steps/15-function-basics/2-rewrite-function-ques…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
09ffe2a 
…tion-or/task.md
@EzequielCaste
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
70b78b8
@EzequielCaste
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bdfa86a
@EzequielCaste
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f92cde2
@EzequielCaste
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
71c8b5f
@EzequielCaste
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
37463e9
@EzequielCaste
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
70e926b
@EzequielCaste
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
03bc402
@EzequielCaste
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d5c47ee
@vplentinax @EzequielCaste
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f6655c0 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
023b516 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
25dfc7f 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f4e78a7 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d944b06 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6e08312 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax
Copy link
Contributor Author

@vplentinax vplentinax commented Jun 16, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Jun 16, 2020
@joaquinelio
joaquinelio reviewed Jul 2, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

varios cambiecitos
Pero muy buen schooling, so dont wait for me
cambia lo que quieras y MERGE

Partimos de un falso "mucho hecho", resignamos a que eran menos de 20.
Ahora 60... ¡UN TERCIO DEL SITIO! Y los PR, dentro del mes.
Qué sino para festejo.
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/15-function-basics/article.md Outdated Show resolved Hide resolved
vplentinax and others added 14 commits Jul 2, 2020
@vplentinax @joaquinelio
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
05538ed 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bd731dc 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7312c8f 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
06a0d8f 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3dde6f3 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
22dec62 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7776d6e 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fb1b96f 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
86af996 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5b73d94 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b889666 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ca8c18d 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9f1b86d 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax @joaquinelio
Update 1-js/02-first-steps/15-function-basics/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bd45ddd 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@vplentinax
Copy link
Contributor Author

@vplentinax vplentinax commented Jul 2, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Jul 2, 2020
@joaquinelio
joaquinelio approved these changes Jul 3, 2020
View changes
@vplentinax vplentinax merged commit ca8f297 into javascript-tutorial:master Jul 3, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jul 3, 2020

Error: the article has another translator @Giorgiosaud, not @vplentinax in the Progress Issue #17. Please update the progress issue or ask maintainers to do so.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzequielCaste EzequielCaste

@joaquinelio joaquinelio

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@vplentinax @javascript-translate-bot @joaquinelio @EzequielCaste
You can’t perform that action at this time.