Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map and Set #263

Merged
merged 24 commits into from Jul 5, 2020
Merged

Map and Set #263

merged 24 commits into from Jul 5, 2020

Conversation

@vplentinax
Copy link
Contributor

@vplentinax vplentinax commented Jun 18, 2020

Arreglado los errores de formato.
@vplentinax
mapset
Loading status checks…
cd5ac90
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Jun 18, 2020
@iliakan iliakan mentioned this pull request Jun 18, 2020
Open
159 of 174 tasks complete
@EzequielCaste EzequielCaste self-requested a review Jul 4, 2020
@EzequielCaste
EzequielCaste requested changes Jul 4, 2020
View changes
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

Hay error al comienzo de 1-js/05-data-types/07-map-set/02-filter-anagrams/solution.md
No se ha respetado los números de las líneas. Debe comenzar en línea N° 1 y no en la N°2.

Por favor corregir así puedo seguir con la revisión.
1-js/05-data-types/07-map-set/01-array-unique-map/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/01-array-unique-map/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/01-array-unique-map/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/01-array-unique-map/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/01-array-unique-map/task.md Show resolved Hide resolved
1-js/05-data-types/07-map-set/01-array-unique-map/task.md Show resolved Hide resolved
1-js/05-data-types/07-map-set/01-array-unique-map/task.md Show resolved Hide resolved
1-js/05-data-types/07-map-set/01-array-unique-map/task.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jul 4, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@EzequielCaste
update solution
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
981da7f 
arreglé el problema de los espacios.
Por favor tienen que coincidir los números de las líneas con el documento Original.
@EzequielCaste
update task
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e4ceae7 
problemas con la numeración de líneas
@EzequielCaste
update solution
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
78e1bfa 
número de líneas
@EzequielCaste
corrección de líneas
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e61c2a6 
respetar el número de línea
@EzequielCaste
corrección número líneas
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1c79cbe
@EzequielCaste
fixed line numbers
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
883cd95
@EzequielCaste
EzequielCaste requested changes Jul 4, 2020
View changes
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

muchos problemas con espacios donde no deberían estar.
Se debe respetar el número de línea del documento original.
1-js/05-data-types/07-map-set/03-iterable-keys/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/07-map-set/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jul 4, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
vplentinax and others added 12 commits Jul 4, 2020
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e6f57ea 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
af49a81 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
459c874 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f6f6016 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
438b4d7 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e101acc 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/01-array-unique-map/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f754d71 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/03-iterable-keys/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
740687f 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
444e0a5 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
669b0ff 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c3f6fc4 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b2df4f7 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
vplentinax and others added 5 commits Jul 4, 2020
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2c56508 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
74fee8b 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3178435 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax @EzequielCaste
Update 1-js/05-data-types/07-map-set/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3b5c116 
Co-authored-by: Ezequiel Castellanos <51804994+ezzep66@users.noreply.github.com>
@vplentinax
Update task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7dcaca0
@vplentinax
Copy link
Contributor Author

@vplentinax vplentinax commented Jul 4, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Jul 4, 2020
@EzequielCaste
EzequielCaste approved these changes Jul 5, 2020
View changes
@vplentinax vplentinax merged commit 6249f2a into javascript-tutorial:master Jul 5, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jul 5, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Jul 5, 2020 •
edited

@vplentinax @ezzep66
¿Merged? Lo tenía recién en una pestaña para revisión...
Estoy de ACUERDO con los merge aprobados por la trusted people, (después de la carga, revisar el repo entero)
¿pero qué pasó con eso del doble review que pide don Bot?
No me quejo, es saber cuál es el criterio.
@vplentinax
Copy link
Contributor Author

@vplentinax vplentinax commented Jul 5, 2020

En mis PR el segundo review lo doy yo jejeje.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzequielCaste EzequielCaste

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@vplentinax @javascript-translate-bot @joaquinelio @EzequielCaste
You can’t perform that action at this time.