Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets and ranges [...] #296

Merged
merged 8 commits into from Jul 13, 2020
Merged

Sets and ranges [...] #296

merged 8 commits into from Jul 13, 2020

Conversation

@cortizg
Copy link
Contributor

@cortizg cortizg commented Jul 11, 2020 •
edited

No description provided.

@cortizg
traduccion 9-08-sr
Loading status checks…
9ef788e 
typos

typo2

typo en código de ejemplo

typo3
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Jul 11, 2020
@iliakan iliakan mentioned this pull request Jul 11, 2020
Open
159 of 174 tasks complete
@cortizg
Traducción pendiente, revisado en repo RU
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c37f3f5
@cortizg
cortizg reviewed Jul 11, 2020
View changes
Copy link
Contributor Author

@cortizg cortizg left a comment

typos
...pressions/08-regexp-character-sets-and-ranges/1-find-range-1/solution.md Outdated Show resolved Hide resolved
9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Outdated Show resolved Hide resolved
9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Outdated Show resolved Hide resolved
9-regular-expressions/08-regexp-character-sets-and-ranges/article.md

```js run
for(let i=0; i<'𝒳𝒴'.length; i++) {
for(let i = 0; i < '𝒳𝒴'.length; i++) {

This comment has been minimized.

Sign in to view
@cortizg

cortizg Jul 11, 2020
Author Contributor

en las buenas prácticas los operadores deben de estar separados por un espacio, y linter tambièn lo recuerda.

This comment has been minimized.

Sign in to view
@vplentinax

vplentinax Jul 13, 2020
Contributor

Y aquí?

This comment has been minimized.

Sign in to view
@cortizg

cortizg Jul 13, 2020
Author Contributor

ya está listo
@joaquinelio
joaquinelio requested changes Jul 11, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

2 pequeños...
9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Outdated Show resolved Hide resolved
9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jul 11, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
cortizg and others added 4 commits Jul 11, 2020
@cortizg
Update 9-regular-expressions/08-regexp-character-sets-and-ranges/1-fi…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
00478bf 
…nd-range-1/solution.md
@cortizg
Update 9-regular-expressions/08-regexp-character-sets-and-ranges/arti…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a82a73a 
…cle.md
@cortizg @joaquinelio
Update 9-regular-expressions/08-regexp-character-sets-and-ranges/arti…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9eacf64 
…cle.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg @joaquinelio
Update 9-regular-expressions/08-regexp-character-sets-and-ranges/arti…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8201cbb 
…cle.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@cortizg
Copy link
Contributor Author

@cortizg cortizg commented Jul 11, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Jul 11, 2020
@joaquinelio
joaquinelio reviewed Jul 12, 2020
View changes
9-regular-expressions/08-regexp-character-sets-and-ranges/article.md Outdated Show resolved Hide resolved
@joaquinelio
Update 9-regular-expressions/08-regexp-character-sets-and-ranges/arti…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1f62050 
…cle.md


esquiusmi...
aceptaste una bandera, pongo la otra
a desgano, pero para concordar.
@joaquinelio
joaquinelio approved these changes Jul 12, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

👍
@cortizg
Update 9-regular-expressions/08-regexp-character-sets-and-ranges/arti…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
930a0df 
…cle.md
@cortizg
Copy link
Contributor Author

@cortizg cortizg commented Jul 13, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Jul 13, 2020
@cortizg cortizg requested review from vplentinax and removed request for javascript-tutorial/translate-es Jul 13, 2020
@vplentinax
vplentinax approved these changes Jul 13, 2020
View changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Ok..!
@joaquinelio joaquinelio merged commit e192dda into javascript-tutorial:master Jul 13, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jul 13, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio

@vplentinax vplentinax

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@cortizg @javascript-translate-bot @joaquinelio @vplentinax
You can’t perform that action at this time.