Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eval: run a code string #303

Merged
merged 9 commits into from Jul 15, 2020
Merged

Eval: run a code string #303

merged 9 commits into from Jul 15, 2020

Conversation

@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Jul 15, 2020

No description provided.

@joaquinelio
1-99-2 eval
Loading status checks…
b70f45c
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Jul 15, 2020
@iliakan iliakan mentioned this pull request Jul 15, 2020
Open
159 of 174 tasks complete
@joaquinelio
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e790056
@maksumi
maksumi approved these changes Jul 15, 2020
View changes
Copy link
Collaborator

@maksumi maksumi left a comment

Me agrada, no tiene detalle. La mayoría solo son sugerencias alternativas de trad, sólo eso
1-js/99-js-misc/02-eval/1-eval-calculator/solution.md Outdated Show resolved Hide resolved
1-js/99-js-misc/02-eval/1-eval-calculator/solution.md Outdated Show resolved Hide resolved
1-js/99-js-misc/02-eval/1-eval-calculator/solution.md Outdated Show resolved Hide resolved
1-js/99-js-misc/02-eval/article.md Outdated Show resolved Hide resolved
1-js/99-js-misc/02-eval/article.md Outdated Show resolved Hide resolved
1-js/99-js-misc/02-eval/article.md Outdated Show resolved Hide resolved
1-js/99-js-misc/02-eval/article.md Outdated Show resolved Hide resolved
joaquinelio and others added 4 commits Jul 15, 2020
@joaquinelio @maksumi
Update 1-js/99-js-misc/02-eval/1-eval-calculator/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c4ef465 
UH!!
Estoy desolado.
Pero gracias.

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Update solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dc392a0
@joaquinelio @maksumi
Update 1-js/99-js-misc/02-eval/1-eval-calculator/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0fc1688 
No, no más claridad, más corrección. Operando es el miembro, operador es el signo.
Good catch diria un yanqui.

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/99-js-misc/02-eval/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d3125a1 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@maksumi
maksumi approved these changes Jul 15, 2020
View changes
joaquinelio and others added 2 commits Jul 15, 2020
@joaquinelio @maksumi
Update 1-js/99-js-misc/02-eval/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f9641fa 
Jugué un poco, me pareció diabolico mas que "el diablo"
Malvado me gusta mas ahora,,,
estuve tentado a poner "malito" tambien, una chiquilinada.

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Update 1-js/99-js-misc/02-eval/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cfc3adf 
el plural me da igual, 
pero la fluidez mejoro mucho

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@maksumi
maksumi approved these changes Jul 15, 2020
View changes
@joaquinelio @maksumi
Update 1-js/99-js-misc/02-eval/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9f5e957 
UUUHHH
El peligro de empezar a asemejarsse al inglés, 
la falta de conectores.

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
Copy link
Contributor Author

@joaquinelio joaquinelio commented Jul 15, 2020

@maksumi , me gustó tu revissión, todo tenía sesntido. (tambien las comenté)
Lástima ya no quedan review de las 80 con las que empezamos...

Pero esa es la buena noticia, estamos al día y podemos seguir traduciendo.
Array methods es largo y con varios archivos, quizas siga con ese
¿o lo querés?
Tambien puedo limpiar algun otro de 2019...
avisa

hoy aporto poco, mejor hago bigint aunq ess un poco irrelevante
@maksumi
Copy link
Collaborator

@maksumi maksumi commented Jul 15, 2020 •
edited

@maksumi , me gustó tu revissión, todo tenía sesntido. (tambien las comenté)
Lástima ya no quedan review de las 80 con las que empezamos...

Pero esa es la buena noticia, estamos al día y podemos seguir traduciendo.
Array methods es largo y con varios archivos, quizas siga con ese
¿o lo querés?
Tambien puedo limpiar algun otro de 2019...
avisa

hoy aporto poco, mejor hago bigint aunq ess un poco irrelevante

Me hubiera gustado aportar por ello, la timidez gana cuando uno es nuevo y tiene miedo de involucrarse más a fondo por no saber cómo hacerlo o por romper algo en el camino.

Ahorita estoy haciendo ya una traducción pero tal vez hoy quede lista. Como tú consideres necesario, si gustas tómala.

Pd: ¿Aún me cuesta entender el flujo de trabajo de esto o es que olvidaste poner el /done @joaquinelio
@vplentinax vplentinax self-requested a review Jul 15, 2020
@vplentinax
vplentinax approved these changes Jul 15, 2020
View changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Ok.!
@joaquinelio joaquinelio merged commit 80c8685 into javascript-tutorial:master Jul 15, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jul 15, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
@joaquinelio joaquinelio deleted the joaquinelio:jeval branch Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maksumi maksumi

@vplentinax vplentinax

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@joaquinelio @maksumi @javascript-translate-bot @vplentinax
You can’t perform that action at this time.