Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Walking the DOM #318

Merged
merged 24 commits into from Jul 29, 2020
Merged

Walking the DOM #318

merged 24 commits into from Jul 29, 2020

Conversation

@Leired7
Copy link
Contributor

@Leired7 Leired7 commented Jul 24, 2020

Artículo, task y soluciones traducido
Leired7 added 7 commits Jul 24, 2020
@Leired7
Walking the DOM - Caminando por el DOM
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
a7e09ce 
Traducido "Walking the DOM"
@Leired7
Traducido
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
b3677bc
@Leired7
Traducido
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
4a85d1c
@Leired7
Traducido
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
99a2bcf
@Leired7
Traducido
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
8d86196
@Leired7
Traducido
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
62dab4d
@Leired7
Cambiado "niño" por "hijo"
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
242f006
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Jul 24, 2020 •
edited

CLA assistant check
All committers have signed the CLA.
@joaquinelio joaquinelio self-requested a review Jul 24, 2020
@joaquinelio
joaquinelio requested changes Jul 24, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment •
edited

Buena adición al repo,

algún typo,
algún cambio de construcción opinable (que podes ignorar y marcar resuelto)

Esstuve tentado a pedir algo más neutral de "una pega"
pero, argentino, la entendí, es perfecta.

Vamos segundo reviewer, ven a reviegüesear...

EDIT: nota, Don Segundo Reviewer: el bot no lo reconoció, lo agrego a mano. Arreglé el nombre supongo que con DOM mayúsculas lo verá cuando merge. Verificar...
2-ui/1-document/03-dom-navigation/1-dom-children/solution.md Outdated Show resolved Hide resolved
2-ui/1-document/03-dom-navigation/article.md Outdated Show resolved Hide resolved
2-ui/1-document/03-dom-navigation/article.md Outdated Show resolved Hide resolved
2-ui/1-document/03-dom-navigation/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jul 24, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@joaquinelio joaquinelio changed the title Walking the dom Walking the DOM Jul 25, 2020
@iliakan iliakan mentioned this pull request Jul 25, 2020
Open
159 of 174 tasks complete
@maksumi
maksumi reviewed Jul 25, 2020
View changes
Copy link
Collaborator

@maksumi maksumi left a comment

Muy buena traducción. Solo arreglar unos tipos y considerar algunas sugerencias para mantener un lenguaje simple en la traducción
2-ui/1-document/03-dom-navigation/1-dom-children/task.md Outdated Show resolved Hide resolved
2-ui/1-document/03-dom-navigation/3-navigation-links-which-null/task.md Outdated Show resolved Hide resolved
2-ui/1-document/03-dom-navigation/article.md Outdated Show resolved Hide resolved
2-ui/1-document/03-dom-navigation/article.md Outdated Show resolved Hide resolved
2-ui/1-document/03-dom-navigation/article.md Outdated Show resolved Hide resolved
2-ui/1-document/03-dom-navigation/article.md Outdated Show resolved Hide resolved
2-ui/1-document/03-dom-navigation/article.md Outdated Show resolved Hide resolved
2-ui/1-document/03-dom-navigation/article.md Outdated Show resolved Hide resolved
2-ui/1-document/03-dom-navigation/article.md Outdated Show resolved Hide resolved
2-ui/1-document/03-dom-navigation/article.md Outdated Show resolved Hide resolved
Leired7 and others added 13 commits Jul 27, 2020
@Leired7 @joaquinelio
Update 2-ui/1-document/03-dom-navigation/1-dom-children/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
67bd1d3 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/1-document/03-dom-navigation/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6cc23a4 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/1-document/03-dom-navigation/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6a28723 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @joaquinelio
Update 2-ui/1-document/03-dom-navigation/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7fac6f6 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7 @maksumi
Update 2-ui/1-document/03-dom-navigation/1-dom-children/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bbbd56e 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7 @maksumi
Update 2-ui/1-document/03-dom-navigation/3-navigation-links-which-nul…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
38348d2 
…l/task.md

Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7 @maksumi
Update 2-ui/1-document/03-dom-navigation/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c15ada0 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7 @maksumi
Update 2-ui/1-document/03-dom-navigation/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2e3d02f 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7 @maksumi
Update 2-ui/1-document/03-dom-navigation/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fbaaed1 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7 @maksumi
Update 2-ui/1-document/03-dom-navigation/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1501fe9 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7 @maksumi
Update 2-ui/1-document/03-dom-navigation/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
04ec290 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7 @maksumi
Update 2-ui/1-document/03-dom-navigation/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f416a1c 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7 @maksumi
Update 2-ui/1-document/03-dom-navigation/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0796f8b 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7 Leired7 closed this Jul 27, 2020
@Leired7 Leired7 reopened this Jul 27, 2020
@Leired7 @maksumi
Update 2-ui/1-document/03-dom-navigation/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b9880b2 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7 Leired7 closed this Jul 27, 2020
@Leired7 Leired7 reopened this Jul 27, 2020
@Leired7 @maksumi
Update 2-ui/1-document/03-dom-navigation/1-dom-children/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
59135ff 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@Leired7 Leired7 requested a review from joaquinelio Jul 27, 2020
@Leired7
Copy link
Contributor Author

@Leired7 Leired7 commented Jul 27, 2020

/done
@Leired7 Leired7 closed this Jul 27, 2020
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Jul 27, 2020

@Leired7 ... ¿closed?
Supongo que ya estaba listo para última mirada e integrarlo,
¿puedo suponer que fue un error de "dóndehagoclicahora"? je je tuve muchos de esos cuando empecé con la traducción...
@Leired7
Copy link
Contributor Author

@Leired7 Leired7 commented Jul 28, 2020

Síiii @joaquinelio!!!! exactamente paso eso! ¿Dónde "tengoqueclickarahora"?
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Jul 28, 2020

No problem...
El autor puede cerrarlo para modificar sin que nadie lo moleste y reabrirlo o dejarlo cerrado y hacer uno nuevo, no pasa nada.
Acá abajo, "Reopen and comment"...
Pero como dijiste que fuer por error, me tenté y abro y reviso...
@joaquinelio joaquinelio reopened this Jul 28, 2020
joaquinelio and others added 2 commits Jul 28, 2020
@joaquinelio @maksumi
Update 2-ui/1-document/03-dom-navigation/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
02b92bd 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio @maksumi
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
eb16ae9 
Co-authored-by: Maksumi Murakami <maksumimurakami@gmail.com>
@joaquinelio
joaquinelio approved these changes Jul 28, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

No es perfecto, (sutilezas intraducibles)
pero menos será si hacemos de la redacción una asamblea.
Apliqué un par de sug de maksumi, dejé un par afuera, y otra que hice y no supe mejorar.
Funciona como está.
@Leired7
Copy link
Contributor Author

@Leired7 Leired7 commented Jul 28, 2020

Muchas gracias por la ayuda ☺️ @joaquinelio
@maksumi
maksumi approved these changes Jul 28, 2020
View changes
@maksumi
Copy link
Collaborator

@maksumi maksumi commented Jul 28, 2020

Merge it! Ya llegará el momento de detallar las sutilezas
@vplentinax vplentinax merged commit 9002711 into javascript-tutorial:master Jul 29, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jul 29, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
@Leired7
Copy link
Contributor Author

@Leired7 Leired7 commented Jul 29, 2020

¡Qué alegría! jejej Gracias!!!

A por el siguiente....
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbritto-dev dbritto-dev

@joaquinelio joaquinelio

@maksumi maksumi

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@Leired7 @CLAassistant @javascript-translate-bot @joaquinelio @maksumi @dbritto-dev @vplentinax
You can’t perform that action at this time.