Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling #330

Merged
merged 23 commits into from Aug 1, 2020
Merged

Scrolling #330

merged 23 commits into from Aug 1, 2020

Conversation

@Leired7
Copy link
Contributor

@Leired7 Leired7 commented Jul 31, 2020

Traducido

Leired7 added 8 commits Jul 27, 2020
@joaquinelio joaquinelio self-requested a review Jul 31, 2020
@iliakan iliakan mentioned this pull request Jul 31, 2020
159 of 174 tasks complete
Copy link
Contributor

@joaquinelio joaquinelio left a comment

"Destraduje" propiedades o conceptos que debe conocer en inglés :
relativo a window, limites top-bottom,
Donde se explaya lo dejé en español, salvo donde lo remarca: bottom y se refiere al código

2-ui/3-event-details/8-onscroll/article.md Outdated Show resolved Hide resolved
2-ui/3-event-details/8-onscroll/article.md Outdated Show resolved Hide resolved
2-ui/3-event-details/8-onscroll/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Leired7 and others added 10 commits Aug 1, 2020
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7
Copy link
Contributor Author

@Leired7 Leired7 commented Aug 1, 2020

/done

@vplentinax
Copy link
Contributor

@vplentinax vplentinax commented Aug 1, 2020

@Leired7 , aún quedaron cambios sin hacer. Fíjate siempre si hay datos "hidden", suelen ocultarlos para no hacer la lista muy larga. 🙈

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Leired7 and others added 4 commits Aug 1, 2020
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Leired7
Copy link
Contributor Author

@Leired7 Leired7 commented Aug 1, 2020

/done

Copy link
Contributor

@joaquinelio joaquinelio left a comment

👍

Copy link
Contributor

@vplentinax vplentinax left a comment

Yes!

@joaquinelio joaquinelio merged commit 06417d2 into javascript-tutorial:master Aug 1, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.