Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date and Time #352

Merged
merged 30 commits into from Aug 28, 2020
Merged

Date and Time #352

merged 30 commits into from Aug 28, 2020

Conversation

@Fedebornaz
Copy link
Contributor

@Fedebornaz Fedebornaz commented Aug 18, 2020

Traducción del artículo Date and Time con sus respectivos ejercicios.
@Fedebornaz
Traducción del artículo Date and Time
Loading status checks…
81b3a90
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Aug 18, 2020 •
edited

CLA assistant check
All committers have signed the CLA.
@maksumi
Copy link
Collaborator

@maksumi maksumi commented Aug 19, 2020

Revisando
@joaquinelio
joaquinelio requested changes Aug 19, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

ok, lindo trabajo

Linea 97
agregaie ``` que falta (marca el final de un box), que no puedo agregar como suggest
ademass con eso los nros de linea van a coincidir
1-js/05-data-types/11-date/1-new-date/solution.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/3-weekday/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/4-get-date-ago/solution.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/4-get-date-ago/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/4-get-date-ago/task.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Aug 19, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@iliakan iliakan mentioned this pull request Aug 19, 2020
Open
159 of 174 tasks complete
Fedebornaz and others added 19 commits Aug 19, 2020
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/1-new-date/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0230231 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/3-weekday/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5ed3cfa 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/4-get-date-ago/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c815759 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/4-get-date-ago/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3d69f63 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/4-get-date-ago/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8ed2752 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/5-last-day-of-month/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b5bf760 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/5-last-day-of-month/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d60abda 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
79c88fb 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
415e063 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4f5de13 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/8-format-date-relative/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f619ed7 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
602a2d1 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4fce385 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6c114e2 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
401c423 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
80b74c7 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz @joaquinelio
Update 1-js/05-data-types/11-date/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6b4af91 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@Fedebornaz
agregados caracteres de cierre de box en línea 97
d53946c
@Fedebornaz
Merge branch 'date-and-time' of https://github.com/Fedebornaz/es.java…
Loading status checks…
ee2b149 
…script.info into date-and-time
@Fedebornaz
Copy link
Contributor Author

@Fedebornaz Fedebornaz commented Aug 19, 2020

/done
joaquinelio added 4 commits Aug 19, 2020
@joaquinelio
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
48e5264
@joaquinelio
Update task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b59c98c
@joaquinelio
Update solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
191567f
@joaquinelio
Update article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1f4722f
@joaquinelio
joaquinelio approved these changes Aug 19, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

Me atreví a hacer unos commits así pasamos directamente a 2da revisión,
typos, "función", "desde" en una suggest mia, la s me falla (también sos revisor de mis revisiones, podes leerlas, cambiarlas, discutirlas) y

y , pido disculpas, volví atrás la sugerencia timestamp. Habia buscado mal la primera referencia, está perfectamente definida al principio. Así que saqué la re-definicipon desprolija que hice más adelante.
@maksumi
Copy link
Collaborator

@maksumi maksumi commented Aug 19, 2020 •
edited

Estaba revisando este artículo pero no podré cumplir con él a buena hora. Par no detenerlo más, pido la ayuda de @vplentinax, @EzequielCaste o algún otro reviewer que se tome la molestia de venir por aquí, leer el comentario y quiera echar una manita de gato con esto. Mil gracias de antemano
@vplentinax
vplentinax requested changes Aug 27, 2020
View changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Pequeñas cositas, el resto correcto. Corregido esto, aprobamos.
1-js/05-data-types/11-date/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/article.md Outdated Show resolved Hide resolved
1-js/05-data-types/11-date/2-get-week-day/solution.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Aug 27, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
Fedebornaz and others added 4 commits Aug 28, 2020
@Fedebornaz @vplentinax
Update 1-js/05-data-types/11-date/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1147101 
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
@Fedebornaz @vplentinax
Update 1-js/05-data-types/11-date/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f3bdfca 
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
@Fedebornaz @vplentinax
Update 1-js/05-data-types/11-date/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
63681a2 
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
@Fedebornaz @vplentinax
Update 1-js/05-data-types/11-date/2-get-week-day/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
450593e 
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
@Fedebornaz
Copy link
Contributor Author

@Fedebornaz Fedebornaz commented Aug 28, 2020

Muchas gracias @vplentinax y @joaquinelio por tomarse el tiempo para hacer las reviews! Veo que la mayoría de las correcciones que me hicieron fueron typos, voy a investigar si hay alguna extensión de VSCode de corrector ortográfico que esté buena. Si tienen alguna otra herramienta que recomienden les agradezco!
@Fedebornaz
Copy link
Contributor Author

@Fedebornaz Fedebornaz commented Aug 28, 2020

/done
@vplentinax
vplentinax approved these changes Aug 28, 2020
View changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Ok!
vplentinax added 2 commits Aug 28, 2020
@vplentinax
Update solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
046c2fc 
Según repo EN.
@vplentinax
Update solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e343aa2 
Según repo EN
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Aug 28, 2020

alguna extensión de VSCode de corrector ortográfico que esté buena. Si tienen alguna otra herramienta que recomienden les agradezco!

@Fedebornaz don maksumi recomendó
Spanish code spell checker
pero no lo probé... y sigo con los typos...
@joaquinelio joaquinelio merged commit c944cdf into javascript-tutorial:master Aug 28, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio

@vplentinax vplentinax

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Fedebornaz @CLAassistant @maksumi @javascript-translate-bot @joaquinelio @vplentinax
You can’t perform that action at this time.