Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-window communication #367

Merged
merged 11 commits into from Sep 1, 2020
Merged

Cross-window communication #367

merged 11 commits into from Sep 1, 2020

Conversation

@homero304
Copy link
Contributor

@homero304 homero304 commented Sep 1, 2020

Please review my PR
@homero304
Cross-window communication
Loading status checks…
41565d2
@joaquinelio joaquinelio self-requested a review Sep 1, 2020
@joaquinelio
joaquinelio requested changes Sep 1, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment •
edited

Bot no puso #pr al issue, ojo reviewerrs

me acabo de dar cuenta de q Ilya peca de "en otras palabras"
pero no voy a leer el coso este de nuevo,
aviso por si alguien tiene ganas de mechar alternativas, "e decir"
por ahi ni vale la pena
el coso ete esta bueno, cambio menores solo ssugeridos
no pierdan tiempo que vaya a merge
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Sep 1, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@iliakan iliakan mentioned this pull request Sep 1, 2020
Open
159 of 174 tasks complete
homero304 and others added 4 commits Sep 1, 2020
@homero304 @joaquinelio
Update 3-frames-and-windows/03-cross-window-communication/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f15ce6d 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304 @joaquinelio
Update 3-frames-and-windows/03-cross-window-communication/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ff63369 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304 @joaquinelio
Update 3-frames-and-windows/03-cross-window-communication/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
270a488 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304 @joaquinelio
Update 3-frames-and-windows/03-cross-window-communication/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
220f440 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304
Copy link
Contributor Author

@homero304 homero304 commented Sep 1, 2020

/done
@joaquinelio
joaquinelio approved these changes Sep 1, 2020
View changes
@EzequielCaste
EzequielCaste requested changes Sep 1, 2020
View changes
Copy link
Contributor

@EzequielCaste EzequielCaste left a comment

Super Bien la traducción 💯 🎉

algunos comentarios que podríamos debatir. nada grave...

Muchas gracias por tu aporte.
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
3-frames-and-windows/03-cross-window-communication/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Sep 1, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
homero304 and others added 6 commits Sep 1, 2020
@homero304 @EzequielCaste
Update 3-frames-and-windows/03-cross-window-communication/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f7adb65 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@homero304 @EzequielCaste
Update 3-frames-and-windows/03-cross-window-communication/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0682c4f 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@homero304 @EzequielCaste
Update 3-frames-and-windows/03-cross-window-communication/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a276b4b 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@homero304 @EzequielCaste
Update 3-frames-and-windows/03-cross-window-communication/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fd63b84 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@homero304 @EzequielCaste
Update 3-frames-and-windows/03-cross-window-communication/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7701bdc 
Co-authored-by: Ezequiel Castellanos <51804994+EzequielCaste@users.noreply.github.com>
@homero304
line:266 cadenas->strings
Loading status checks…
0726d44
@homero304
Copy link
Contributor Author

@homero304 homero304 commented Sep 1, 2020

/done
@EzequielCaste
EzequielCaste approved these changes Sep 1, 2020
View changes
@EzequielCaste EzequielCaste merged commit 4a84bb5 into javascript-tutorial:master Sep 1, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Sep 1, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio

@EzequielCaste EzequielCaste

Assignees
No one assigned
Labels
needs +1 review needed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@homero304 @javascript-translate-bot @joaquinelio @EzequielCaste
You can’t perform that action at this time.