Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadow DOM #386

Merged
merged 3 commits into from Oct 7, 2020
Merged

Shadow DOM #386

merged 3 commits into from Oct 7, 2020

Conversation

@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Sep 22, 2020

y sombras serán

No pude traducir las herramientas de chrome porque lo tengo en inglés:
More tools > developer tools > (engranaje) > show user agent shadow dom
agregárelo quien pudiere
@joaquinelio
sombrasnadamas
Loading status checks…
fcb4102
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Sep 22, 2020
@javascript-translate-bot javascript-translate-bot mentioned this pull request Sep 22, 2020
Open
159 of 174 tasks complete
@vplentinax
vplentinax requested changes Sep 23, 2020
View changes
Copy link
Contributor

@vplentinax vplentinax left a comment

¿En qué línea está lo que dices?
8-web-components/3-shadow-dom/article.md Outdated Show resolved Hide resolved
8-web-components/3-shadow-dom/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Sep 23, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@joaquinelio @vplentinax
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c29ea2e 
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
@joaquinelio
Copy link
Contributor Author

@joaquinelio joaquinelio commented Sep 23, 2020 •
edited

linea 15
necesitamos habilitar la opción "Show user agent shadow DOM" en "herramientas".

Supongo, que es "herramientas", supongo que es "herramientas de desarrollo"
pero no queria adivinar "Show user agent shadow DOM"

ah, done
=)
@joaquinelio
Copy link
Contributor Author

@joaquinelio joaquinelio commented Sep 23, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Sep 23, 2020
@vplentinax
vplentinax requested changes Oct 7, 2020
View changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Si, en las herramientas de desarrollo.
8-web-components/3-shadow-dom/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Oct 7, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@joaquinelio @vplentinax
"herramientas de desarrollo"
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ea751c2 
Ok.
¿buscaste "Show user agent shadow DOM"?

Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
@joaquinelio
Copy link
Contributor Author

@joaquinelio joaquinelio commented Oct 7, 2020

Ok.
¿buscaste "Show user agent shadow DOM"?
@vplentinax
Copy link
Contributor

@vplentinax vplentinax commented Oct 7, 2020 •
edited

Haz merge, ya que tu eres como el segundo "reviwer" y así avanzamos más.
@joaquinelio
Copy link
Contributor Author

@joaquinelio joaquinelio commented Oct 7, 2020

Es que me había entusiasmado ahora que parecía concurrido...

Pero está, bien, el procedimiento lo permite.
@joaquinelio joaquinelio merged commit c24c603 into javascript-tutorial:master Oct 7, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Oct 7, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
@joaquinelio joaquinelio deleted the joaquinelio:shadows branch Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vplentinax vplentinax

Assignees
No one assigned
Labels
changes requested
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@joaquinelio @javascript-translate-bot @vplentinax
You can’t perform that action at this time.