Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript animations #389

Merged
merged 8 commits into from Oct 2, 2020
Merged

JavaScript animations #389

merged 8 commits into from Oct 2, 2020

Conversation

@homero304
Copy link
Contributor

@homero304 homero304 commented Sep 27, 2020

please review my PR
@homero304
JavaScript animations
Loading status checks…
a66466f
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Sep 27, 2020
@javascript-translate-bot javascript-translate-bot mentioned this pull request Sep 27, 2020
Open
159 of 174 tasks complete
@homero304
Merge branch 'master' into JavaScript-animations
Loading status checks…
f725617
@joaquinelio
joaquinelio approved these changes Sep 28, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

Esta perfecto
nimiedades si queres cambiar puse suggest,
cambies o no ok para online
7-animation/3-js-animation/article.md Outdated Show resolved Hide resolved
7-animation/3-js-animation/article.md Outdated Show resolved Hide resolved
7-animation/3-js-animation/article.md Outdated Show resolved Hide resolved
7-animation/3-js-animation/article.md

Surely we could improve it, add more bells and whistles, but JavaScript animations are not applied on a daily basis. They are used to do something interesting and non-standard. So you'd want to add the features that you need when you need them.
Seguramente podríamos mejorarlo, agregar más campanas y silbidos, pero las animaciones de JavaScript no se aplican a diario. Se utilizan para hacer algo interesante y no estándar. Por lo tanto, querrás agregar las funciones que necesitas cuando las necesites.

This comment has been minimized.

Sign in to view
@joaquinelio

joaquinelio Sep 28, 2020
Contributor

estaria bien...
pero es expresion muy usada que se pierde traducida
agregar mas...
...fanfarria, barroco , trompetas y bombos...
no tengo sugerencia sorry :-P
y menos que no sea regional

This comment has been minimized.

Sign in to view
@homero304

homero304 Sep 28, 2020
Author Contributor

no se que ponerle tampoco X.X creo que la dejare asi..
7-animation/3-js-animation/article.md Outdated Show resolved Hide resolved
homero304 and others added 6 commits Sep 28, 2020
@homero304 @joaquinelio
Update 7-animation/3-js-animation/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
92cee06 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304 @joaquinelio
Update 7-animation/3-js-animation/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ffe2c40 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304
435: dibujalo -> dibujar
f4af1b9
@homero304 @joaquinelio
Update 7-animation/3-js-animation/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0c775af 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@homero304
152,453: Bezier -> Bézier
6aaf733
@homero304
Merge branch 'JavaScript-animations' of https://github.com/homero304/…
Loading status checks…
5af278e 
…es.javascript.info into JavaScript-animations
@vplentinax
vplentinax approved these changes Oct 1, 2020
View changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Oki
@joaquinelio joaquinelio merged commit 095fb6f into javascript-tutorial:master Oct 2, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Oct 2, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Oct 2, 2020 •
edited

@homero304
ah...
es algo que añadimos, silvidos es dificil de añadir
agregarle "pitos/silbatos y campanas" al programa era mas razonable, jaja
tarde
pero NO importa
no voy a hacer un pr para eso
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio

@vplentinax vplentinax

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@homero304 @javascript-translate-bot @joaquinelio @vplentinax
You can’t perform that action at this time.