Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods of RegExp and String #414

Merged
merged 53 commits into from Oct 12, 2020
Merged

Methods of RegExp and String #414

merged 53 commits into from Oct 12, 2020

Conversation

@dbritto-dev
Copy link
Contributor

@dbritto-dev dbritto-dev commented Oct 9, 2020

No description provided.

dbritto-dev added 2 commits Oct 9, 2020
@dbritto-dev
Update article
1e65c04
@dbritto-dev
Minor changes
Loading status checks…
54be322
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Oct 9, 2020
@javascript-translate-bot javascript-translate-bot mentioned this pull request Oct 9, 2020
Open
159 of 174 tasks complete
@dbritto-dev
Copy link
Contributor Author

@dbritto-dev dbritto-dev commented Oct 9, 2020

@joaquinelio yo creo que ahora ya esta bien
@joaquinelio
joaquinelio requested changes Oct 9, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment •
edited

  • Si rescribis en lugar de usar las suggest, cuida los acentos que les agregué/quité
  • una de las correccione esta sin suggest porque el md con graves me lo impide
  • para mi es valido "retornar" como el "devolver" que sugerimos en todos lados, no se que piensan otros. Sugerimos consistencia pero no creo que esto confunda a nadie.
  • no creo que debas usarr lista en lugar de array, para quien solo sepa js lista no tiene entidad. No lo puse en suggest porque en el momento dudaba...
9-regular-expressions/17-regexp-methods/article.md Outdated Show resolved Hide resolved
9-regular-expressions/17-regexp-methods/article.md Outdated Show resolved Hide resolved
9-regular-expressions/17-regexp-methods/article.md Outdated Show resolved Hide resolved
9-regular-expressions/17-regexp-methods/article.md Outdated Show resolved Hide resolved
9-regular-expressions/17-regexp-methods/article.md Outdated Show resolved Hide resolved
9-regular-expressions/17-regexp-methods/article.md Outdated Show resolved Hide resolved
9-regular-expressions/17-regexp-methods/article.md Outdated Show resolved Hide resolved
9-regular-expressions/17-regexp-methods/article.md Show resolved Hide resolved
9-regular-expressions/17-regexp-methods/article.md Outdated Show resolved Hide resolved
9-regular-expressions/17-regexp-methods/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Oct 9, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
dbritto-dev and others added 7 commits Oct 9, 2020
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8ef9599 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4d41571 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7b2518f 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7a16104 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1e5511a 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8751d21 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
16d7b40 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev
dbritto-dev reviewed Oct 9, 2020
View changes
9-regular-expressions/17-regexp-methods/article.md Outdated Show resolved Hide resolved
9-regular-expressions/17-regexp-methods/article.md Outdated Show resolved Hide resolved
dbritto-dev and others added 12 commits Oct 9, 2020
@dbritto-dev
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
d68d2e5
@dbritto-dev
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
926c7e8
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
67526f9 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ca29636 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3ba321c 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
478c5c6 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
369b9c0 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3ecea79 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8096bbb 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f24cab8 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0c276b1 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3c5ed4a 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
dbritto-dev and others added 6 commits Oct 9, 2020
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
9e5ef9a 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
a2e4467 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e9c5ba7 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f55acf7 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bd7e456 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
89d3487 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev
dbritto-dev reviewed Oct 9, 2020
View changes
9-regular-expressions/17-regexp-methods/article.md Outdated Show resolved Hide resolved
@dbritto-dev
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bb0743e
@dbritto-dev
Copy link
Contributor Author

@dbritto-dev dbritto-dev commented Oct 9, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Oct 9, 2020
@joaquinelio
joaquinelio requested changes Oct 9, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

AAAHHHH!!!
¿¿¿Lo pase al ingles con el signo "!" ????? sorrysorrysorrysorrysorry

linea 274
supongo que w+ es solamente "world"

ya está, me quemé.
perdon si los arrastre a uds tambien...
9-regular-expressions/17-regexp-methods/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Oct 9, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@dbritto-dev @joaquinelio
Update 9-regular-expressions/17-regexp-methods/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cd3db66 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@dbritto-dev
Copy link
Contributor Author

@dbritto-dev dbritto-dev commented Oct 9, 2020

/done
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Oct 9, 2020
@joaquinelio
joaquinelio approved these changes Oct 9, 2020
View changes
@vplentinax
vplentinax approved these changes Oct 12, 2020
View changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Ok
@joaquinelio joaquinelio merged commit cab278a into javascript-tutorial:master Oct 12, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Oct 12, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio

@vplentinax vplentinax

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@dbritto-dev @javascript-translate-bot @vplentinax @joaquinelio
You can’t perform that action at this time.