Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forms: event and method submit #454

Merged
merged 16 commits into from Dec 14, 2020
Merged

Forms: event and method submit #454

merged 16 commits into from Dec 14, 2020

Conversation

@puntope
Copy link
Contributor

@puntope puntope commented Dec 9, 2020

No description provided.

puntope added 5 commits Dec 9, 2020
@puntope
Forms: event and method submit
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
21fb24e
@puntope
Update task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
af25299
@puntope
Update solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
62f6bc5
@puntope
Update index.html
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
7a8321a
@puntope
Update index.html
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a1bf500
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Dec 9, 2020
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Dec 9, 2020 •
edited

CLA assistant check
All committers have signed the CLA.
@joaquinelio
joaquinelio requested changes Dec 10, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

bienvenido

algunos acentos,
las cuestiones de forma podes ignorarme, el articulo es muy claro

tuviste el criterio de traducir value pero no name o type...
aja...
es que siempre ando buscando reviewers, aunque el bot te ignore podes dejar las correcciones y comentarios

otra forma de ayudar,
cada tanto hacemos merge desde ingles,
cuando hay más de un par de lineas descarto los cambios y los paso a issues. "actualizar"
Por un lado es mas facil porque es menos cantidad,
por otro lado mas complejo porque hay que comparar con el repo ingles,
revisar el historial de commits, y corregir los nros de lineas (me ayudo con vscode +gitlens que hace diff con cualquier remoto)
2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md Outdated Show resolved Hide resolved
.../4-forms-controls/4-forms-submit/1-modal-dialog/solution.view/index.html Outdated Show resolved Hide resolved
2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/4-forms-submit/article.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md Outdated Show resolved Hide resolved
2-ui/4-forms-controls/4-forms-submit/article.md Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Dec 10, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Dec 10, 2020

Cambio titulo, agrego al issue a mano
confirmarlo al hacer merge
@joaquinelio joaquinelio changed the title Forms event and method submit Forms: event and method submit Dec 10, 2020
@joaquinelio joaquinelio mentioned this pull request Dec 10, 2020
Open
159 of 174 tasks complete
puntope and others added 9 commits Dec 10, 2020
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ed8bf56 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a3f2a94 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.v…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d5f8910 
…iew/index.html

Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b7350f2 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9164cba 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9e2559a 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/solution.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a1e0e94 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8132ed7 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/1-modal-dialog/task.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f782995 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope
Copy link
Contributor Author

@puntope puntope commented Dec 10, 2020

/done
@puntope puntope closed this Dec 10, 2020
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Dec 10, 2020
@puntope puntope reopened this Dec 10, 2020
@puntope
Copy link
Contributor Author

@puntope puntope commented Dec 10, 2020

/done
@joaquinelio
Copy link
Contributor

@joaquinelio joaquinelio commented Dec 10, 2020 •
edited

hola, @puntope
casi ok
eeehhh... quedaron dos sin resolver,
de los que no negocio, "a veces" y un typo

edit
ah, ok: pereza de github "2 hidden...show more"
puntope and others added 2 commits Dec 10, 2020
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
91715b7 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope @joaquinelio
Update 2-ui/4-forms-controls/4-forms-submit/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7cbe071 
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
@puntope
Copy link
Contributor Author

@puntope puntope commented Dec 10, 2020

/done
@joaquinelio
joaquinelio approved these changes Dec 10, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment

wow that s was fast
...

yes!
👍

waiting for the second reviewer now...
@vplentinax
vplentinax approved these changes Dec 13, 2020
View changes
Copy link
Contributor

@vplentinax vplentinax left a comment

Todo bien...
@joaquinelio joaquinelio merged commit 85b14d2 into javascript-tutorial:master Dec 14, 2020
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Dec 14, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
@puntope puntope deleted the puntope:Forms-event-and-method-submit branch Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaquinelio joaquinelio

@vplentinax vplentinax

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@puntope @CLAassistant @javascript-translate-bot @joaquinelio @vplentinax
You can’t perform that action at this time.