Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation #16

Open
wants to merge 15 commits into
base: master
from
Open

French translation #16

wants to merge 15 commits into from

Conversation

@olivierlacan
Copy link

@olivierlacan olivierlacan commented May 19, 2018

Hi there,

I've started working on the French translation. Haven't gotten far but I'm about to solicit community help so I thought a PR would be the appropriate way to gather assistance from my fellow Frenchies.

Thanks again for all your work on this project. I'm glad it's finally on ruby-lang.org.

Useful resources:

@easydatawarehousing
Copy link
Collaborator

@easydatawarehousing easydatawarehousing commented May 21, 2018

Hi,

That is good news. The more translations the merrier. It is indeed a lot of work. The Dutch translation took me 3 days if I remember correct. I'm afraid my knowledge of French is far too limited to help out ...

@@ -0,0 +1,26 @@
---
lang: EN

This comment has been minimized.

@sunny

sunny May 23, 2018
Contributor

FR perhaps? (Samewise on the other files.)

@@ -0,0 +1,26 @@
---
lang: EN
title: Vous avez 30 minutes? Essayez Ruby!

This comment has been minimized.

@sunny

sunny May 23, 2018
Contributor

In French, a space must come before double ponctuations like ? or !.


La beauté de Ruby se situe dans sa balance entre simplicité et puissance.

Vous pouvez saisir du code Ruby dans l'éditeur et utiliser les boutons suivants pour naviguer:

This comment has been minimized.

@sunny

sunny May 23, 2018
Contributor

A space is missing before the colon.

This comment has been minimized.

@olivierlacan

olivierlacan May 23, 2018
Author

Oh, English has ruined me.

- __Back__ → Vous permet de revenir à la leçon précédente
- __Clear__ → Remets l'éditeur à zéro

Utilise le bouton 'planête' <span aria-hidden="true" class="glyphicon glyphicon-globe"></span>

This comment has been minimized.

@sunny

sunny May 23, 2018
Contributor

Perhaps we should use double-quotes here? E.g.:

  • « planête »
  • ❝planête❞
  • "planête"

This comment has been minimized.

@olivierlacan

olivierlacan May 23, 2018
Author

First one's the most correct for French "guillemets". Yet.

Utilise le bouton 'planête' <span aria-hidden="true" class="glyphicon glyphicon-globe"></span>
ci-dessus pour changer le language de TryRuby.

### Clique sur __Next__ pour commencer à apprendre.

This comment has been minimized.

@sunny

sunny May 23, 2018
Contributor

If we are to use the tu (the friendly choice), this should be used everywhere instead of the vous (the formal choice).

This comment has been minimized.

@olivierlacan

olivierlacan May 23, 2018
Author

Absolutely, I'd rather default to friendlier. Québécois-style 😸

title: Le résumé #2 est arrivé
answer: \w+
class: stretcher chapmark
load: poem = "My toast has flown from my hand\nAnd my toast has gone to the moon.\nBut when I saw it on television,\nPlanting our flag on Halley's comet,\nMore still did I want to eat it.\n"

This comment has been minimized.

@sunny

sunny May 23, 2018
Contributor

Shouldn't the poem also be translated?

This comment has been minimized.

@olivierlacan

olivierlacan May 23, 2018
Author

Didn't know if that'd work but we can.

error:
---

Jettons un oeil à ce qui s'est passé pendant ta deuxième minute:

This comment has been minimized.

@sunny

sunny May 23, 2018
Contributor

minute: -> minute :

Jettons un oeil à ce qui s'est passé pendant ta deuxième minute:

### Erreurs
Si tu essayes d'inverser un nombre ou de faire des choses bizzares, Ruby

This comment has been minimized.

@sunny

sunny May 23, 2018
Contributor

essayes -> essaies

Jettons un oeil à ce qui s'est passé pendant ta deuxième minute:

### Erreurs
Si tu essayes d'inverser un nombre ou de faire des choses bizzares, Ruby

This comment has been minimized.

@sunny

sunny May 23, 2018
Contributor

bizzares -> bizarres


Changeons de direction pour un instant. J'ai mis un petit bout de poésie
pour toi dans une certaine variable.
Jette un oeil. Saisi:

This comment has been minimized.

@sunny

sunny May 23, 2018
Contributor

Saisi: -> Saisis :

@@ -0,0 +1,26 @@
---
lang: EN
title: Vous avez 30 minutes? Essayez Ruby!

This comment has been minimized.

@sunny

sunny May 23, 2018
Contributor

Perhaps we should prefer tu wherever we use vous in order to use the same everywhere?

@sunny
Copy link
Contributor

@sunny sunny commented May 23, 2018

Hey @olivierlacan, that is awesome \o/

I started a bunch of review comments, but perhaps you would rather I contribute as commits?

@olivierlacan
Copy link
Author

@olivierlacan olivierlacan commented May 23, 2018

@sunny I'm down for commits too but the comments are really useful as well.

Copy link
Contributor

@sunny sunny left a comment

New comments for French chapter 1

@@ -0,0 +1,12 @@
---
lang: FR
title: Maintenant entre ticket

This comment has been minimized.

@sunny

sunny May 24, 2018
Contributor

This title doesn't sound as good in french as it does in english. Perhaps Maintenant saisis ticket? Or Maintenant entre ton ticket / Maintenant donne ton ticket (a kind of play on words).

title: Le résumé #2 est arrivé
answer: \w+
class: stretcher chapmark
load: poem = "My toast has flown from my hand\nAnd my toast has gone to the moon.\nBut when I saw it on television,\nPlanting our flag on Halley's comet,\nMore still did I want to eat it.\n"

This comment has been minimized.

@sunny

sunny May 24, 2018
Contributor

I suggest translating it.

This PR over your branch introduces this poem, translated: olivierlacan#2

@@ -0,0 +1,13 @@
---
lang: FR
title: Un d'entre eux lève la main

This comment has been minimized.

@sunny

sunny May 24, 2018
Contributor

I would suggest L'un d'entre eux rather than Un d'entre eux, which sounds better to me.

Mais que faire si on a besoin d'un élement specifique de la liste?

### [ ]
Ruby utilise des crochets droits [ ] pour viser un élement.

This comment has been minimized.

@sunny

sunny May 24, 2018
Contributor

In french I think we would simply say crochets for [] (and accolades for {}).

---

Eh, c'est pas grave. T'es pas obligé d'aimer ça. Laisses toi aller et
améliore mon poème. Au lieu d'une biscotte, tu peux essayer un melon

This comment has been minimized.

@sunny

sunny May 24, 2018
Contributor

In order to change the poem in french, we should find two feminin or two masculine things so that the poem doesn't look weird when one word is replaced by another.

E.g. un toast and un melon, or une biscotte and une citrouille.

@sunny
Copy link
Contributor

@sunny sunny commented May 24, 2018

I also did other minor fixes as a pull-request over your branch : olivierlacan#1

error: Ça sent toujours la biscotte pour moi
---

Eh, c'est pas grave. T'es pas obligé d'aimer ça. Laisses toi aller et

This comment has been minimized.

@sunny

sunny May 25, 2018
Contributor

I would have rather used Écoute, c'est pas grave. rather than Eh, c'est pas grave, here.


Eh, c'est pas grave. T'es pas obligé d'aimer ça. Laisses toi aller et
améliore mon poème. Au lieu d'une biscotte, tu peux essayer un melon
pourquoi pas. Essaie de voir ce nouveau poème:

This comment has been minimized.

@sunny

sunny May 25, 2018
Contributor

Here par exemple sounds better in French to me than pourquoi pas.

This comment has been minimized.

@sunny

sunny May 25, 2018
Contributor

I would simply have used Essaie rather than Essaie de voir.

@easydatawarehousing
Copy link
Collaborator

@easydatawarehousing easydatawarehousing commented Jul 2, 2018

Hi guys, please let me know if I can do anything. I figured that since not all lesson content is translated I don't have to merge yet.

@olivierlacan
Copy link
Author

@olivierlacan olivierlacan commented Jul 3, 2018

@easydatawarehousing All good. Still a WIP. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.