C#: More data-flow caching#4837
Closed
hvitved wants to merge 4 commits into
Closed
Conversation
81491df to
89ba4ab
Compare
… `FormatUnusedArgument.ql`
This forces the negation body of `localFlowStepPlus` to be restricted to nodes in
`localFlowEntry`, as the negation can otherwise be slow to comput:
```
[2020-12-21 11:17:22] (83s) Tuple counts for DataFlowImpl::LocalFlowBigStep::localFlowStepPlus#ffffff#shared/2@93020e:
14483346 ~0% {2} r1 = JOIN DataFlowImplCommon::LocalCallContext::relevantFor_dispred#ff_10#join_rhs AS L WITH DataFlowPublic::Node::getEnclosingCallable_dispred#ff_10#join_rhs AS R ON FIRST 1 OUTPUT R.<1> 'arg0', L.<1> 'arg1'
14201809 ~0% {2} r2 = r1 AND NOT DataFlowImpl::LocalFlowBigStep::localFlowStepPlus#ffffff#antijoin_rhs AS R(r1.<0> 'arg0', r1.<1> 'arg1')
```
89ba4ab to
64010b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/697/
https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/701/
https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/705/
https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/712/