Skip to content

Docs: Fix CSS for "pull-quotes" and expandable sections#4873

Merged
shati-patel merged 2 commits into
github:mainfrom
shati-patel:docs-formatting
Jan 5, 2021
Merged

Docs: Fix CSS for "pull-quotes" and expandable sections#4873
shati-patel merged 2 commits into
github:mainfrom
shati-patel:docs-formatting

Conversation

@shati-patel

@shati-patel shati-patel commented Dec 23, 2020

Copy link
Copy Markdown
Contributor

Two small CSS fixes that I've already pushed to the live site:

c2fdb47: Only the first line (i.e. the title) of the "pull-quote" should be bold, rather than some of the list items being randomly bold.

More details

For example:

Before:

image

After:

image

I double-checked that all pull-quotes do indeed have a title, so we don't accidentally highlight the first line of a paragraph. (For ref: $ grep -r -A 2 '.. pull-quote::' --include="*.rst")

dc52876: One of the arrow symbols () got converted to the ▶️ emoji, while the other one () remained a symbol (as intended). I've added some styling to stop Sphinx from converting either of them to emoji.

More details

For example:

Before:

image

After:

image

@shati-patel shati-patel changed the title Docs: Fix CSS for "pull-quotes" Docs: Fix CSS for "pull-quotes" and expandable sections Dec 23, 2020

@hubwriter hubwriter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shati-patel shati-patel merged commit 2702b65 into github:main Jan 5, 2021
@shati-patel shati-patel deleted the docs-formatting branch January 5, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants