Html comment #4875
Merged
Html comment #4875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This change looks good to me. Thanks for pointing this out. @madneal Could you rebase the branch to remove the spurious commits? @jf205 Could you merge this change if you are happy with it. I wondered whethered this file is handwritten or generated from some other source. If it's generated we should of course fix the problem at the source. |
Contributor
Author
|
@aibaars rebased |
Contributor
Author
|
@aibaars one more commit, the LineComment and BlockComment should be the same level too |
shati-patel
approved these changes
Jan 5, 2021
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Looks good to me! I'll get this merged shortly.
(@jf205 is unavailable, so I've taken a look on his behalf.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.