Check deprecated functions at compilation time#3972
Merged
nobu merged 4 commits intoruby:masterfrom Jun 30, 2021
Merged
Conversation
a3ee015 to
ae242f4
Compare
Member
Author
|
Failed with |
c7362be to
f140533
Compare
f140533 to
6b35d1c
Compare
At compilation time with RUBY_DEBUG enabled, check if the removal version has been reached.
6b35d1c to
5c37d1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
rb_warn_deprecated_to_removeshows the deprecation warning with the version to remove. Often we can miss it however, especially as now deprecation warnings are suppressed by default. It's better to notice automatically, probably at build-time.This is not perfect, but it can detect the miss at least a few jobs in the CIs.
Also, this changes the message not to print the future version, as @shyouhei said.
Feature #17432