Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DPLL algorithm #3866

Merged
merged 8 commits into from Nov 8, 2020
Merged

DPLL algorithm #3866

merged 8 commits into from Nov 8, 2020

Conversation

@Shivanirudh
Copy link
Contributor

@Shivanirudh Shivanirudh commented Nov 6, 2020 •
edited by cclauss

Describe your change:

Added DPLL algorithm

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@Shivanirudh
DPLL algorithm
Loading status checks…
dde4611
@cclauss
cclauss reviewed Nov 6, 2020
View changes
other/dpll.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Nov 6, 2020
View changes
other/dpll.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Nov 6, 2020
View changes
other/dpll.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Nov 6, 2020
View changes
other/dpll.py Outdated Show resolved Hide resolved
Shivanirudh added 3 commits Nov 7, 2020
@Shivanirudh
Corrections complete
Loading status checks…
be92721
@Shivanirudh
Formatting
Loading status checks…
17e7019
@Shivanirudh
Codespell hook
Loading status checks…
e95dd93
@Shivanirudh Shivanirudh requested a review from cclauss Nov 7, 2020
@cclauss
cclauss reviewed Nov 7, 2020
View changes
other/dpll.py Outdated Show resolved Hide resolved
other/dpll.py Outdated Show resolved Hide resolved
other/dpll.py Outdated Show resolved Hide resolved
other/dpll.py Outdated Show resolved Hide resolved
other/dpll.py Outdated Show resolved Hide resolved
other/dpll.py Outdated Show resolved Hide resolved
other/dpll.py Outdated Show resolved Hide resolved
other/dpll.py Outdated Show resolved Hide resolved
other/dpll.py Outdated Show resolved Hide resolved
other/dpll.py Outdated Show resolved Hide resolved
@cclauss
cclauss requested changes Nov 7, 2020
View changes
Copy link
Member

@cclauss cclauss left a comment

B
Shivanirudh added 2 commits Nov 8, 2020
@Shivanirudh
Corrections part 2
Loading status checks…
33f370e
@Shivanirudh
Corrections v2
Loading status checks…
3bae8f4
@Shivanirudh Shivanirudh requested a review from cclauss Nov 8, 2020
@cclauss
cclauss requested changes Nov 8, 2020
View changes
Copy link
Member

@cclauss cclauss left a comment

We are getting there...
other/dpll.py Outdated Show resolved Hide resolved
other/dpll.py Outdated Show resolved Hide resolved
other/dpll.py Outdated Show resolved Hide resolved
other/dpll.py Outdated Show resolved Hide resolved
other/dpll.py Outdated Show resolved Hide resolved
other/dpll.py Outdated Show resolved Hide resolved
other/dpll.py Outdated Show resolved Hide resolved
@Shivanirudh
Corrections v3
Loading status checks…
3a0d65b
@Shivanirudh Shivanirudh requested a review from cclauss Nov 8, 2020
@cclauss
Update and rename dpll.py to davis–putnam–logemann–loveland.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
cc74417
@cclauss
cclauss approved these changes Nov 8, 2020
View changes
Copy link
Member

@cclauss cclauss left a comment •
edited

cc74417 I renamed the file to be self-documenting and made several optimizations including defining a .__len__() method and catching the RecursionError.
@cclauss cclauss merged commit eab6b70 into TheAlgorithms:master Nov 8, 2020
2 checks passed
2 checks passed
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
@Shivanirudh
Copy link
Contributor Author

@Shivanirudh Shivanirudh commented Nov 8, 2020

Yeah, thank you very much!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Shivanirudh @cclauss
You can’t perform that action at this time.