Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add crawl_google_scholar_citation.py #3879

Merged
merged 12 commits into from Nov 13, 2020
Merged

add crawl_google_scholar_citation.py #3879

merged 12 commits into from Nov 13, 2020

Conversation

@boyuuuun
Copy link
Contributor

@boyuuuun boyuuuun commented Nov 11, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
boyuuuun added 2 commits Nov 11, 2020
@boyuuuun
add crawl_google_scholar_citation.py
3e5e9a3
@boyuuuun
pass flack8
Loading status checks…
47efd43
@boyuuuun boyuuuun requested a review from cclauss as a code owner Nov 11, 2020
boyuuuun added 5 commits Nov 11, 2020
@boyuuuun
pass isort
Loading status checks…
e08b235
@boyuuuun
pass isort
Loading status checks…
a614c9d
@boyuuuun
change comment in main
Loading status checks…
0ee618f
@boyuuuun
modify main code
Loading status checks…
14c55a7
@boyuuuun
delete file
Loading status checks…
a97c312
@cclauss
cclauss requested changes Nov 13, 2020
View changes
web_programming/crawl_google_scholar_citation.py Outdated Show resolved Hide resolved
web_programming/crawl_google_scholar_citation.py Outdated Show resolved Hide resolved
web_programming/crawl_google_scholar_citation.py Outdated Show resolved Hide resolved
web_programming/crawl_google_scholar_citation.py Outdated Show resolved Hide resolved
web_programming/crawl_google_scholar_citation.py Outdated Show resolved Hide resolved
@boyuuuun
change how to build url
Loading status checks…
6c3d24d
@cclauss
cclauss reviewed Nov 13, 2020
View changes
web_programming/crawl_google_scholar_citation.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Nov 13, 2020
View changes
web_programming/crawl_google_scholar_citation.py Outdated Show resolved Hide resolved
boyuuuun and others added 4 commits Nov 13, 2020
@boyuuuun
add a key 'hl' in params dict
Loading status checks…
3ee5392
@cclauss
Update crawl_google_scholar_citation.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7cf27f6
@cclauss
Create crawl_google_results.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d0b60d2
@cclauss
codespell: Mater
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0a206ec
@cclauss cclauss requested a review from dhruvmanila as a code owner Nov 13, 2020
@cclauss
cclauss approved these changes Nov 13, 2020
View changes
Copy link
Member

@cclauss cclauss left a comment

Looks really slick! Thanks for your persistence.
@cclauss cclauss merged commit 32def4b into TheAlgorithms:master Nov 13, 2020
2 checks passed
2 checks passed
pre-commit
Details
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

@dhruvmanila dhruvmanila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@boyuuuun @cclauss
You can’t perform that action at this time.