Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42406: Fix whichmodule() with multiprocessing #23403

Open
wants to merge 1 commit into
base: master
from
Open

bpo-42406: Fix whichmodule() with multiprocessing #23403

wants to merge 1 commit into from

Conversation

@renatolfc
Copy link

@renatolfc renatolfc commented Nov 19, 2020 •
edited by bedevere-bot

This fixes the behavior of the pickle.whichmodule() function when multiprocessing is imported before the pickle module.

Prior to this patch, the following incorrect output would be found when trying to determine the module of the (for example) gdtrix function:

>>> import multiprocessing
>>> import pickle
>>> from scipy.special import gdtrix
>>> pickle.whichmodule(gdtrix, gdtrix.__name__)
'__mp_main__'

With the patch, now we get correct behavior:

>>> import multiprocessing
>>> import pickle
>>> from scipy.special import gdtrix
>>> pickle.whichmodule(gdtrix, gdtrix.__name__)
'scipy.special._ufuncs'

This also fixes uqfoundation/dill#392.

Signed-off-by: Renato L. de F. Cunha renatoc@br.ibm.com

https://bugs.python.org/issue42406
@renatolfc
bpo-42406: Fix whichmodule() with multiprocessing
Loading status checks…
88969fa 
Signed-off-by: Renato L. de F. Cunha <renatoc@br.ibm.com>
@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Nov 19, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@renatolfc

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed awaiting review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Serialization of `ufunc`s breaks depending on import order
3 participants
@renatolfc @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.