Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated PR bot #8

Open
pganssle opened this issue Feb 21, 2020 · 0 comments
Open

Automated PR bot #8

pganssle opened this issue Feb 21, 2020 · 0 comments

Comments

@pganssle
Copy link
Member

@pganssle pganssle commented Feb 21, 2020

We should create an automated PR bot that watches for releases and makes a PR automatically if it detects a change.

I can see two fairly simple ways of doing this:

  1. Run tox -e update and see if git diff shows any substantive change (depending on how #5 is resolved update.py may end up "resetting" all non-IANA version components even if the version hasn't changed).
  2. Change update.py to store a hash of the most recent tarball(s) somewhere in the repository and generate a PR whenever that changes.

I think the biggest challenge is preventing it from generating multiple PRs if it is triggered more than once before the first one is merged, which requires maintaining some state somewhere. Possibly that's easy enough to do because presumably the bot needs its own fork of the repository (or a branch on the main repository), and if the branch name is the same as the IANA version we can just not create the PR if the branch exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.