Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42700: Swap descriptions in pyexpat.errors #23876

Merged
merged 1 commit into from Dec 29, 2020

Conversation

goodmami
Copy link
Contributor

@goodmami goodmami commented Dec 21, 2020

The descriptions of the codes and messages dictionaries in
xml.parsers.expat.errors were swapped, and this commit swaps them
back. For example, codes maps string descriptions of errors to numeric
error codes, not the other way around.

https://bugs.python.org/issue42700

The descriptions of the `codes` and `messages` dictionaries in
`xml.parsers.expat.errors` were swapped, and this commit swaps them
back. For example, `codes` maps string descriptions of errors to numeric
error codes, not the other way around.
ghost
ghost approved these changes Dec 22, 2020
Copy link

@ghost ghost left a comment

LGTM

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

LGTM.

@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

Thanks @goodmami for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 29, 2020
The descriptions of the `codes` and `messages` dictionaries in
`xml.parsers.expat.errors` were swapped, and this commit swaps them
back. For example, `codes` maps string descriptions of errors to numeric
error codes, not the other way around.
(cherry picked from commit 84402eb)

Co-authored-by: Michael Wayne Goodman <goodman.m.w@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 29, 2020

GH-23994 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 29, 2020
The descriptions of the `codes` and `messages` dictionaries in
`xml.parsers.expat.errors` were swapped, and this commit swaps them
back. For example, `codes` maps string descriptions of errors to numeric
error codes, not the other way around.
(cherry picked from commit 84402eb)

Co-authored-by: Michael Wayne Goodman <goodman.m.w@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 29, 2020

GH-23995 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Dec 29, 2020
The descriptions of the `codes` and `messages` dictionaries in
`xml.parsers.expat.errors` were swapped, and this commit swaps them
back. For example, `codes` maps string descriptions of errors to numeric
error codes, not the other way around.
(cherry picked from commit 84402eb)

Co-authored-by: Michael Wayne Goodman <goodman.m.w@gmail.com>
miss-islington added a commit that referenced this pull request Dec 29, 2020
The descriptions of the `codes` and `messages` dictionaries in
`xml.parsers.expat.errors` were swapped, and this commit swaps them
back. For example, `codes` maps string descriptions of errors to numeric
error codes, not the other way around.
(cherry picked from commit 84402eb)

Co-authored-by: Michael Wayne Goodman <goodman.m.w@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
The descriptions of the `codes` and `messages` dictionaries in
`xml.parsers.expat.errors` were swapped, and this commit swaps them
back. For example, `codes` maps string descriptions of errors to numeric
error codes, not the other way around.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants