Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-27794: Add `name` attribute to `property` class #23967

Merged
merged 8 commits into from Dec 30, 2020
Merged

bpo-27794: Add `name` attribute to `property` class #23967

merged 8 commits into from Dec 30, 2020

Conversation

@uriyyo
Copy link
Contributor

@uriyyo uriyyo commented Dec 27, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue27794
@uriyyo
Add `name` attribute to `property` class
Loading status checks…
de0962b
@uriyyo
Fix property test cases
Loading status checks…
a041466
@rhettinger rhettinger self-assigned this Dec 27, 2020
@uriyyo
Fix issue with incorrect exc message
Loading status checks…
89b5b21
@uriyyo uriyyo force-pushed the uriyyo:fix-issue-27794 branch from ef7003a to 89b5b21 Dec 27, 2020
@uriyyo
remove `name` from `property` init method
Loading status checks…
f02f68c
@rhettinger
rhettinger reviewed Dec 28, 2020
View changes
Objects/descrobject.c Outdated Show resolved Hide resolved
@rhettinger
rhettinger reviewed Dec 28, 2020
View changes
Misc/NEWS.d/next/Core and Builtins/2020-12-27-18-07-43.bpo-27794.sxgfGi.rst Outdated Show resolved Hide resolved
@rhettinger
rhettinger requested changes Dec 28, 2020
View changes
Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 28, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@rhettinger
rhettinger reviewed Dec 28, 2020
View changes
Objects/descrobject.c Show resolved Hide resolved
@rhettinger
rhettinger reviewed Dec 28, 2020
View changes
Objects/descrobject.c Show resolved Hide resolved
uriyyo added 2 commits Dec 28, 2020
@uriyyo
Make name attribute private
Loading status checks…
b502907
@uriyyo
fix docs
Loading status checks…
6aa55bd
@uriyyo
Copy link
Contributor Author

@uriyyo uriyyo commented Dec 28, 2020

I have made the requested changes; please review again
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 28, 2020

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.
@bedevere-bot bedevere-bot requested a review from rhettinger Dec 28, 2020
@rhettinger
rhettinger requested changes Dec 29, 2020
View changes
Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
Objects/descrobject.c Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 29, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@uriyyo
Remove strip call from docs, remove extra blank line
Loading status checks…
2c83769
@uriyyo
Copy link
Contributor Author

@uriyyo uriyyo commented Dec 29, 2020

I have made the requested changes; please review again
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 29, 2020

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.
@bedevere-bot bedevere-bot requested a review from rhettinger Dec 29, 2020
@rhettinger
rhettinger requested changes Dec 29, 2020
View changes
Objects/descrobject.c Outdated Show resolved Hide resolved
Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
Doc/howto/descriptor.rst Outdated Show resolved Hide resolved
Objects/descrobject.c Outdated Show resolved Hide resolved
Objects/descrobject.c Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 29, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@uriyyo
Update docs and property __set_name__ method
Loading status checks…
d2b4e63
@uriyyo
Copy link
Contributor Author

@uriyyo uriyyo commented Dec 29, 2020

I have made the requested changes; please review again
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 29, 2020

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.
@bedevere-bot bedevere-bot requested a review from rhettinger Dec 29, 2020
@rhettinger rhettinger merged commit c56387f into python:master Dec 30, 2020
11 checks passed
11 checks passed
Docs
Details
Check for source changes
Details
Check if generated files are up to date
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20201229.34 succeeded
Details
Travis CI - Pull Request Build Passed
Details
bedevere/issue-number Issue number 27794 found
Details
bedevere/news News entry found in Misc/NEWS.d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger

Assignees

@rhettinger rhettinger

Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@uriyyo @bedevere-bot @rhettinger @the-knights-who-say-ni
You can’t perform that action at this time.